[nfc] lower test timeouts #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikea
force-pushed
the
maizatskyi/2024-08-21-test-timeouts
branch
5 times, most recently
from
fdb8fd2
to
bfeac15
Compare
mikea
commented
Aug 21, 2024
| @@ -26,10 +26,124 @@ kj_test( | |||
| deps = ["//src/workerd/tests:test-fixture"], | |||
| ) | |||
|
|
|||
| [wd_test( | |||
| src = f, | |||
| wd_test( | |||
There was a problem hiding this comment.
some tests are large, so rather than deal with excludes I expanded this. Hope you don't mind @anonrig
mikea
force-pushed
the
maizatskyi/2024-08-21-test-timeouts
branch
from
bfeac15
to
b619cb0
Compare
npaun
approved these changes
Aug 21, 2024
fhanau
approved these changes
Aug 21, 2024
anonrig
approved these changes
Aug 21, 2024
|
@mikea Make sure you have all tests that need to be tagged as large/enormous, including under ASan – bazel may or may not list tests as failed if the cached test time is larger than the time limit, and if a test is narrowly below a threshold it should be bumped to the higher level to avoid flakiness. |
mikea
force-pushed
the
maizatskyi/2024-08-21-test-timeouts
branch
from
b619cb0
to
221e005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.