Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove response stream disconnected status gate #2638

Merged

Conversation

joshthoward
Copy link
Collaborator

No description provided.

@joshthoward joshthoward requested review from a team as code owners September 1, 2024 00:52
@joshthoward joshthoward force-pushed the joshthoward/ungate-response-stream-disconnected-status branch from e52e5cb to f39f152 Compare September 1, 2024 01:11
@jclee
Copy link
Contributor

jclee commented Sep 3, 2024

Thanks! This looks good to me, but probably worth keeping in mind that the internal web-socket-proxy test in edgeworker currently covers the behavior difference between the two autogate settings, so it would also need to be updated at the same time as the workerd dependency that removes the conditional behavior. I believe it is simply a matter of merging the versions of the tests with all-autogates and not-all-autogates test results (I think the relevant tests can be found by grepping for RESPONSE_STREAM_DISCONNECTED_STATUS). Let me know if you'd like me to help.

@joshthoward joshthoward force-pushed the joshthoward/ungate-response-stream-disconnected-status branch from f39f152 to f1148c6 Compare September 26, 2024 20:40
@joshthoward joshthoward force-pushed the joshthoward/ungate-response-stream-disconnected-status branch from f1148c6 to f67203a Compare September 27, 2024 22:13
@joshthoward
Copy link
Collaborator Author

The internal PR is passing checks and approved. I am going to go ahead and merge, update the internal PR to point to the merge commit, and then merge the internal PR. Please LMK if that isn't the right process.

@joshthoward joshthoward merged commit 6fa86ee into main Sep 29, 2024
13 of 14 checks passed
@joshthoward joshthoward deleted the joshthoward/ungate-response-stream-disconnected-status branch September 29, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants