Extend SqliteDatabase with a reset() method that recreates the database #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
force-pushed
the
kenton/sqlite-reset
branch
from
deb6d4e
to
7198dad
Compare
jasnell
reviewed
Sep 9, 2024
| // Delete all: increments start over | ||
| await doReq('deleteAll'); | ||
| assert.equal(await doReq('increment'), 1); | ||
| assert.equal(await doReq('increment'), 2); |
There was a problem hiding this comment.
nit: a variation on this that also waits on these concurrently would be nice.
const results = await Promise.all([
doReq('deleteAll'),
doReq('increment'),
doReq('increment'),
]);
assert.deepStrictEqual(results, ...);Largely to make sure that operations are correctly sequenced.
There was a problem hiding this comment.
I don't understand... what would that test that is interesting here?
kentonv
force-pushed
the
kenton/sqlite-reset
branch
3 times, most recently
from
97d14b5
to
b97ec2a
Compare
justin-mp
approved these changes
Sep 10, 2024
Note that `deleteAll()` has never been possible to perform as part of a transaction in production, so this should not be considered a breaking change. Also this particular code is not (yet) reachable in production anyway.
This can be used to re-enable WAL mode, and other things that need to happen at startup.
…bject" This log has served its purpose (it turns out people do, in fact, call deleteAll() with an alarm set fairly often). It is also getting in the way of deleteAll() for SRS-backed objects since they don't implement alarms yet so the getAlarm() call throws. This reverts commit 2f13452.
This doesn't really matter for workerd, where the commit callback is a no-op. It matters in production, though.
kentonv
force-pushed
the
kenton/sqlite-reset
branch
from
b97ec2a
to
cf8c335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use this to implement deleteAll().
Thus,
deleteAll()will now delete SQL tables as well, instead of just KV data.