Implements Python import statement parser to avoid ast module. #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
force-pushed
the
dominik/EW-8677
branch
9 times, most recently
from
0c27713
to
dab3faa
Compare
dom96
requested review from
harrishancock,
Frederik-Baetens,
jp4a50,
hoodmane and
garrettgu10
jp4a50
reviewed
Sep 17, 2024
| } | ||
| } | ||
|
|
||
| // XXX: jsg doesn't support kj::Vector return types, so this seems to be the only way to do this. |
There was a problem hiding this comment.
dom96
force-pushed
the
dominik/EW-8677
branch
3 times, most recently
from
f05253e
to
eb48eae
Compare
dom96
force-pushed
the
dominik/EW-8677
branch
from
eb48eae
to
caf6c4c
Compare
jp4a50
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a simple parser which looks for
import <module>andfrom <module> import <symbol>statements in Python code. Transitions the package memory snapshot generation to use this new parser which resolves issues with the snapshot leaking user code (previous code used Python's ast module to parse the files which meant they were loaded into memory and had a chance of being captured by the snapshot).Tested upstream and using the new pyodide-test unit tests.