Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to log the stack where cross-request promises are being resolved #2760

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 20, 2024

I don't think we want to keep this is forever ...

Since we don't have a way of testing log output yet in workerd it's difficult to test this reliably. Here's what the log output currently looks from the test (just a sampling)

...
workerd/server/server.c++:3851: debug: [ TEST ] cross-context-promise-test:asyncIterWorks
workerd/server/server.c++:3859: debug: [ PASS ] cross-context-promise-test:asyncIterWorks
workerd/server/server.c++:3851: debug: [ TEST ] cross-context-promise-test:crossContextRejectWorks
workerd/io/worker.c++:1213: warning: NOSENTRY Warning: Cross Request Promise Resolve
    at Object.reject (<anonymous>)
    at rejectTest (worker:238:23)
    at Object.fetch (worker:142:14)
workerd/server/server.c++:3859: debug: [ PASS ] cross-context-promise-test:crossContextRejectWorks
workerd/server/server.c++:3851: debug: [ TEST ] cross-context-promise-test:crossContextResolveWorks
workerd/io/worker.c++:1213: warning: NOSENTRY Warning: Cross Request Promise Resolve
    at Object.resolve (<anonymous>)
    at worker:200:44
    at resolveTest (worker:200:7)
    at Object.fetch (worker:140:14)
workerd/server/server.c++:3859: debug: [ PASS ] cross-context-promise-test:crossContextResolveWorks
workerd/server/server.c++:3851: debug: [ TEST ] cross-context-promise-test:crossContextStreamWorks
workerd/io/worker.c++:1213: warning: NOSENTRY Warning: Cross Request Promise Resolve
    at crossRequestStream (worker:268:32)
    at Object.fetch (worker:144:14)
workerd/server/server.c++:3859: debug: [ PASS ] cross-context-promise-test:crossContextStreamWorks
workerd/server/server.c++:3851: debug: [ TEST ] cross-context-promise-test:customThenableWorks
workerd/io/worker.c++:1213: warning: NOSENTRY Warning: Cross Request Promise Resolve
    at <anonymous>
    at Object.<anonymous> (worker:306:5)
    at Object.apply (node-internal:mock:411:28)
workerd/server/server.c++:3859: debug: [ PASS ] cross-context-promise-test:customThenableWorks
workerd/server/server.c++:3851: debug: [ TEST ] cross-context-promise-test:cyclicAwaitsWorks
...

src/workerd/io/worker.c++ Outdated Show resolved Hide resolved
src/workerd/io/worker.c++ Outdated Show resolved Hide resolved
@jasnell jasnell force-pushed the jsnell/add-logging-for-cross-request-promise-resolve branch from cc97826 to 4ab7ac8 Compare September 20, 2024 19:35
@jasnell jasnell force-pushed the jsnell/add-logging-for-cross-request-promise-resolve branch from 4ab7ac8 to 4f89424 Compare September 25, 2024 23:36
src/workerd/io/worker.c++ Outdated Show resolved Hide resolved
src/workerd/io/worker.c++ Outdated Show resolved Hide resolved
@jasnell jasnell force-pushed the jsnell/add-logging-for-cross-request-promise-resolve branch from 533671e to b661473 Compare October 2, 2024 14:40
@jasnell jasnell requested a review from kentonv October 2, 2024 14:50
@jasnell jasnell merged commit 3f448b3 into main Oct 2, 2024
14 checks passed
@jasnell jasnell deleted the jsnell/add-logging-for-cross-request-promise-resolve branch October 2, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants