Handle errors thrown by reportError in queueMicrotask #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
reviewed
Sep 23, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jasnell
force-pushed
the
jsnell/handle-queuemicrotask-reporterror-errors
branch
from
62e8d9f
to
e9bfcc4
Compare
anonrig
reviewed
Sep 24, 2024
anonrig
approved these changes
Sep 24, 2024
anonrig
approved these changes
Sep 24, 2024
kentonv
reviewed
Sep 25, 2024
jasnell
force-pushed
the
jsnell/handle-queuemicrotask-reporterror-errors
branch
from
73f278f
to
db3740b
Compare
|
Based on feedback from @kentonv ... the PR is updated to simply log the error rather than abort anything. We can work on abort behavior with a compat flag separately once we've had more time to properly plan out consistent unhandled error / unhandled rejection handling that is more reliable. |
That sounds good to me. But I don't see the update yet. |
Grrr... I hadn't noticed that the precommit hook had blocked it. There now. |
jasnell
force-pushed
the
jsnell/handle-queuemicrotask-reporterror-errors
branch
from
f9316d2
to
a7dc424
Compare
|
Linter is complaining about the better formatting so will go with the weird formatting for now. |
kentonv
approved these changes
Sep 25, 2024
jasnell
force-pushed
the
jsnell/handle-queuemicrotask-reporterror-errors
branch
from
a7dc424
to
ca1f902
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.