[o11y] Add convenience functions to add span tags for subrequest #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fhanau
commented
Sep 25, 2024
•
fhanau
commented
- This allows adding initial tags for KV and R2. Also add lw:top_level_execution span.
fhanau
force-pushed
the
felix/subrequest-client-spans
branch
from
36cf832
to
9301352
Compare
fhanau
added a commit
that referenced
this pull request
Sep 29, 2024
Splitting this off of #2799, which will take some more work.
fhanau
force-pushed
the
felix/subrequest-client-spans
branch
from
9301352
to
760b2cf
Compare
fhanau
added a commit
that referenced
this pull request
Sep 29, 2024
Splitting this off of #2799, which will take some more work.
fhanau
added a commit
that referenced
this pull request
Sep 30, 2024
Splitting this off of #2799, which will take some more work.
jclee
pushed a commit
that referenced
this pull request
Oct 11, 2024
Splitting this off of #2799, which will take some more work.
fhanau
force-pushed
the
felix/subrequest-client-spans
branch
2 times, most recently
from
1ad873b
to
2026572
Compare
jasnell
reviewed
Oct 28, 2024
src/workerd/io/io-context.h
Outdated
| @@ -709,6 +725,13 @@ class IoContext final: public kj::Refcounted, private kj::TaskSet::ErrorHandler | |||
| kj::Maybe<kj::String> cfBlobJson, | |||
| kj::ConstString operationName); | |||
|
|
|||
| // As above, but with list of span tags to add, analogous to getSubrequestChannelSpans(). | |||
| kj::Own<kj::HttpClient> getHttpClientSpans(uint channel, | |||
There was a problem hiding this comment.
Bikeshed: The name is slightly confusing/misleading. Something like getHttpClientWithSpans(...) would be slightly clearer here.
jasnell
approved these changes
Oct 28, 2024
fhanau
force-pushed
the
felix/subrequest-client-spans
branch
from
2026572
to
8b5822e
Compare
- This allows adding initial tags for KV and R2. Also add lw:top_level_execution span.
fhanau
force-pushed
the
felix/subrequest-client-spans
branch
from
8b5822e
to
fe4e607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.