Have nodejs_zlib implied by nodejs_compat_v2 #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
requested review from
harrishancock,
ObsidianMinor,
anonrig and
vicb
vicb
approved these changes
Sep 25, 2024
anonrig
approved these changes
Sep 25, 2024
jasnell
force-pushed
the
jsnell/node_zlib_impliedby_nodejs_compat_V2
branch
from
7cab4cf
to
b8ae510
Compare
anonrig
approved these changes
Sep 25, 2024
jasnell
force-pushed
the
jsnell/node_zlib_impliedby_nodejs_compat_V2
branch
from
b8ae510
to
acaa910
Compare
Ensures that if either nodejs_compat or nodejs_compat_v2 are enabled, then nodejs_zlib will be enabled also
jasnell
force-pushed
the
jsnell/node_zlib_impliedby_nodejs_compat_V2
branch
from
acaa910
to
704b836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that if either nodejs_compat or nodejs_compat_v2 are enabled, then nodejs_zlib will be enabled also
There was a limitation in the original definition of the implied by annotation in that it would only allow specifying a single field. The effect was that
nodejs_zlibwould be implied bynodejs_compatbut notnoejs_compat_v2. If I updated it to be implied bynodejs_compat_v2then it would transitively work for bothnodejs_compatandnodejs_compat_v2but wouldn't do the right thing if the worker hadnodejs_compat, no_nodejs_compat_v2... Confusing.This PR modifies the implied by annotation to allow multiple flags to be specified so that it works correct in any combination.