More refactoring to enable Python pools #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
hoodmane/more-pools-refactor
branch
from
1b8c09a
to
153c3b4
Compare
hoodmane
force-pushed
the
hoodmane/more-pools-refactor
branch
from
153c3b4
to
3d225ea
Compare
We won't be able to import `UnsafeEval` directly from `builtin_wrappers.ts` so this adds a `setUnsafeEval` function to inject it from the outside. Similarly, we need everything imported from emscriptenSetup.ts to be bundled, so we don't want to import from topLevelEntropy in builtin_wrappers, so we call `setGetRandomValues` from the outside.
hoodmane
force-pushed
the
hoodmane/more-pools-refactor
branch
from
3d225ea
to
d173557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We won't be able to import
UnsafeEvaldirectly frombuiltin_wrappers.tsso this adds asetUnsafeEvalfunction to inject it from the outside.