Rename GetPrototype() uses to GetPrototypeV2() #2872
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is expected to be relatively temporary. V8 is in the process of deprecating and removing the original `GetPrototype()` implementation. Once that original impl is removed, I believe the plan is to rename `GetPrototypeV2()` back to `GetPrototype()`, at which point we'll likely need to change these back. That's ok, we want to make sure there's no issue with updating to the new behavior well in advance of that.
|
Apparently there is some subtle difference between the two calls if we are calling it on the global object. I didn't understand that, but assuming that we understand that, LGTM. |
anonrig
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
looks good to me. i tried to do a similar research to address @erikcorry's comments, but if we are in par, let's go!
|
In neither of these cases would it really be expected that someone would be passing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is expected to be relatively temporary. V8 is in the process of deprecating and removing the original
GetPrototype()implementation. Once that original impl is removed, I believe the plan is to renameGetPrototypeV2()back toGetPrototype(), at which point we'll likely need to change these back. That's ok, we want to make sure there's no issue with updating to the new behavior well in advance of that.