Restore: Change WorkerInterface so prewarm returns a promise. #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
force-pushed
the
dlapid/prewarm_promise2
branch
from
6a236b3
to
5ef1c92
Compare
danlapid
changed the title
|
Note: I have put all changes from the original PR in a separate commit so you don't have to review the first commit again. |
harrishancock
approved these changes
Oct 10, 2024
Change WorkerInterface so prewarm returns a promise.
danlapid
force-pushed
the
dlapid/prewarm_promise2
branch
from
5ef1c92
to
a0aa485
Compare
kentonv
reviewed
Oct 11, 2024
danlapid
force-pushed
the
dlapid/prewarm_promise2
branch
from
a0aa485
to
c287094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change WorkerInterface so prewarm returns a promise.