Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type for sleep function in Workflows #2890

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

sidharthachatterjee
Copy link
Collaborator

It is currently Promise<void> | void which is incorrect because it always returns a thenable

@sidharthachatterjee sidharthachatterjee changed the title Fix type for Workflows sleep Fix type for sleep function in Workflows Oct 10, 2024
@sidharthachatterjee sidharthachatterjee merged commit 07649d2 into main Oct 10, 2024
12 of 13 checks passed
@sidharthachatterjee sidharthachatterjee deleted the workflows-sleep-type branch October 10, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants