Provide ExecutionModel enum to tail worker #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jasnell
reviewed
Oct 11, 2024
anonrig
reviewed
Oct 11, 2024
src/workerd/api/trace.c++
Outdated
| @@ -284,6 +285,10 @@ kj::StringPtr TraceItem::getOutcome() { | |||
| return outcome; | |||
| } | |||
|
|
|||
| bool TraceItem::getIsActor() { | |||
There was a problem hiding this comment.
Suggested change
| bool TraceItem::getIsActor() { | |
| bool TraceItem::getIsActor() const { |
There was a problem hiding this comment.
I agree that we should be doing this, but this is best done as part of a separate cleanup that applies this for all functions in Trace. Let's keep this PR self-contained if possible.
src/workerd/api/trace.h
Outdated
| @@ -105,6 +105,7 @@ class TraceItem final: public jsg::Object { | |||
|
|
|||
| uint getCpuTime(); | |||
| uint getWallTime(); | |||
| bool getIsActor(); | |||
There was a problem hiding this comment.
Suggested change
| bool getIsActor(); | |
| bool getIsActor() const; |
fhanau
changed the title
jasnell
reviewed
Oct 11, 2024
jasnell
reviewed
Oct 11, 2024
jasnell
approved these changes
Oct 11, 2024
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.