Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: change WorkflowStep into an abstract class #2916

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix: change WorkflowStep into an abstract class #2916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5be53bf
fix: change WorkflowStep into an abstract class
LuisDuarte1 Oct 14, 2024
b46edf2
Merge branch 'main' into lduarte/fix-workflow-step-types
LuisDuarte1 Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 4 additions & 18 deletions types/defines/rpc.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,26 +233,12 @@ declare module "cloudflare:workers" {
timestamp: Date;
};

export type WorkflowStep = {
do:
| (<T extends Rpc.Serializable<T>>(
name: string,
callback: () => Promise<T>
) => Promise<T>)
| (<T extends Rpc.Serializable<T>>(
name: string,
config: WorkflowStepConfig,
callback: () => Promise<T>
) => Promise<T>)
| (<T extends Rpc.Serializable<T>>(
name: string,
config: WorkflowStepConfig | (() => Promise<T>),
callback?: () => Promise<T>
) => Promise<T>);

export abstract class WorkflowStep {
do<T extends Rpc.Serializable<T>>(name: string, callback: () => Promise<T>): Promise<T>;
do<T extends Rpc.Serializable<T>>(name: string, config: WorkflowStepConfig, callback: () => Promise<T>): Promise<T>;
sleep: (name: string, duration: WorkflowSleepDuration) => Promise<void>;
sleepUntil: (name: string, timestamp: Date | number) => Promise<void>;
};
}

export abstract class WorkflowEntrypoint<
Env = unknown,
Expand Down