SQLite: Make foreign key errors on txn commit visible to app. #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed the test was testing for an "internal error", which is always a bug, and implies that in prod an error would have been logged to Sentry. We can make this throw an application-visible error instead. This also makes the test output look less bad.
kentonv
force-pushed
the
kenton/sqlite-foreign-constraint
branch
from
8eea488
to
bcda208
Compare
jasnell
approved these changes
Oct 16, 2024
justin-mp
approved these changes
Oct 16, 2024
geelen
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the test was testing for an "internal error", which is always a bug, and implies that in prod an error would have been logged to Sentry. We can make this throw an application-visible error instead. This also makes the test output look less bad.