add more functions for node:url #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/add-node-url-functions
branch
from
04b7d62
to
e043f54
Compare
jasnell
reviewed
Oct 16, 2024
anonrig
force-pushed
the
yagiz/add-node-url-functions
branch
3 times, most recently
from
69808e4
to
1b00b96
Compare
jasnell
approved these changes
Oct 17, 2024
anonrig
force-pushed
the
yagiz/add-node-url-functions
branch
from
1b00b96
to
b273347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to update
node:pathposix implementation to make sure new functions added tonode:urlis implemented correctly. The last remaining part ofnode:urlis the legacy_url which I'll open a new pull-request to add it.Adds:
fileURLToPathpathToFileURLtoPathIfFileURL