Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Disentangle r2*.c++, memory-cache.c++ from io target #2991

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[build] Disentangle r2*.c++, memory-cache.c++ from io target #2991

merged 1 commit into from
Oct 25, 2024

Conversation

fhanau
Copy link
Collaborator

@fhanau fhanau commented Oct 24, 2024

  • Mark tools:dump_api_ast as no-downstream – this target is expensive and serves no purpose for the downstream build.
  • Disable default dependencies for tracing to drop superfluous crate and match downstream

@fhanau
[build] Disentangle r2*.c++, memory-cache.c++ from io target
355050a 
- Mark tools:dump_api_ast as no-downstream – this target is expensive and
  serves no purpose for the downstream build.
- Disable default dependencies for tracing to drop superfluous crate and match
  downstream
@fhanau fhanau requested a review from mikea October 24, 2024 15:33
@fhanau fhanau marked this pull request as ready for review October 24, 2024 15:33
@fhanau fhanau requested review from a team as code owners October 24, 2024 15:33
@fhanau fhanau requested a review from dom96 October 24, 2024 15:33
@fhanau
Copy link
Collaborator Author

fhanau commented Oct 24, 2024 •
edited
Loading

  • add downstream PR to update bazel deps there as needed

@fhanau fhanau merged commit 09f3380 into main Oct 25, 2024
13 checks passed
@fhanau fhanau deleted the felix/102224-io-shrink branch October 25, 2024 01:10
fhanau added a commit that referenced this pull request Oct 26, 2024
@fhanau
Fail cc_ast_dump when AST dump encounters errors, add missing depende…
e6ddf0f 
…ncies to API AST dump

PR #2991 introduced a regression where the API AST dump did not have access to
all the required includes. However, an incomplete AST was still being generated
despite the missing include error. Add the missing dependencies so that the
correct types are generated and enable pipefail for the ast dump/gzip shell
commands so that the cc_ast_dump action fails if there are any errors being
reported.
@fhanau fhanau mentioned this pull request Oct 26, 2024
Merged
fhanau added a commit that referenced this pull request Oct 26, 2024
@fhanau
Fail cc_ast_dump when AST dump encounters errors, add missing depende…
e01f32e 
…ncies to API AST dump

PR #2991 introduced a regression where the API AST dump did not have access to
all the required includes. However, an incomplete AST was still being generated
despite the missing include error. Add the missing dependencies so that the
correct types are generated and enable pipefail for the ast dump/gzip shell
commands so that the cc_ast_dump action fails if there are any errors being
reported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@mikea mikea Awaiting requested review from mikea

@dom96 dom96 Awaiting requested review from dom96 dom96 is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhanau @jasnell