Implement test case for joining two tables with identical column names #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
kentonv
reviewed
May 24, 2023
src/workerd/api/sql-test.js
Outdated
| SELECT articles.name, users.name | ||
| FROM articles | ||
| INNER JOIN users | ||
| ON articles.user_id = users.id`).raw(); |
There was a problem hiding this comment.
This returns an iterator, but the code below is expecting an array. You need something like let array = [...iter]; to expand it.
|
Yeah I wasn't sure where the bug was coming from, so figured this would be a good test to have |
rozenmd
force-pushed
the
rozenmd/raw-tests
branch
from
6f8da10 to
6e17443
Compare
|
Closing this in favour of #696 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.