JSG Completion: Convert some direct uses of v8::HandleScope to new utility #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
force-pushed
the
jsnell/jsg-completion-use-less-v8-handlescope
branch
from
e585253
to
980234d
Compare
jasnell
force-pushed
the
jsnell/jsg-completion-use-less-v8-handlescope
branch
2 times, most recently
from
59a1d8c
to
a74ef7b
Compare
jasnell
force-pushed
the
jsnell/jsg-completion-use-less-v8-handlescope
branch
from
a74ef7b
to
419a249
Compare
ohodson
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use js.withinHandleScope to replace a number of direct uses of v8::HandleScope. There are more to do but it touches a lot of files and I prefer to make the changes incrementally.