D1 Binding - Null Support - Fixed by latest worker-build I guess - Added support for handling None on First #680
+325
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: I believe the issue is fixed now!
While I was working on isolating the issue, when I updated the build command of the sandbox to also use cargo install -q worker-build, it took some time to return, and then I was no longer able to reproduce it.
AFAIK its fixed and runs fine!
So the relevance of this PR now is just
Previously:
As I mentioned on issue #678 the main problem had to do with the JsValue::Null that for some reason, was somehow overwritten by the Env variable.
So on serialisation it serialised the env variable content, and it seems that on serialisation it still used the same env variable to check if its a null or not.
In practice this meant:
When I tried to reconstruct manually it deserialised just fine, because here the JsValue::NULL is the one referencing the Env and not JsValue(null).