pass arguments to underlying CLIs

.changeset/clever-cooks-smell.md

@@ -0,0 +1,13 @@
+---
+"create-cloudflare": patch
+---
+
+adjusted arguments passing so that arguments following an extra `--` are
+passed to the underlying cli (if any)
+
+For example:
+```
+$ npm create cloudflare -- --framework=X -- -a -b
+```
+now will run the framework X's cli with the `-a` and `-b` arguments
+(such arguments will be completely ignored by C3)

packages/create-cloudflare/src/cli.ts

@@ -83,8 +83,12 @@ const printBanner = () => {
 	startSection(`Create an application with Cloudflare`, "Step 1 of 3");
 };
 
-export const parseArgs = async (argv: string[]): Promise<Partial<C3Args>> => {
-	const args = await yargs(hideBin(argv))
+const parseArgs = async (argv: string[]): Promise<Partial<C3Args>> => {
+	const doubleDashesIdx = argv.indexOf('--');
+	const c3Args = doubleDashesIdx < 0 ? argv : argv.slice(0, doubleDashesIdx < 0 ? undefined : doubleDashesIdx);
+	const additionalArgs = doubleDashesIdx < 0 ? [] : argv.slice(doubleDashesIdx + 1);
+
+	const args = await yargs(hideBin(c3Args))
 		.scriptName("create-cloudflare")
 		.usage("$0 [args]")
 		.positional("name", { type: "string" })
@@ -115,6 +119,7 @@ export const parseArgs = async (argv: string[]): Promise<Partial<C3Args>> => {
 		...(args.wranglerDefaults && WRANGLER_DEFAULTS),
 		...(args.acceptDefaults && C3_DEFAULTS),
 		projectName: args._[0] as string | undefined,
+		additionalArgs,
 		...args,
 	};
 };

packages/create-cloudflare/src/helpers/command.ts

@@ -180,6 +180,10 @@ export const runFrameworkGenerator = async (
 	ctx: PagesGeneratorContext,
 	cmd: string
 ) => {
+	if(ctx.framework?.args?.length) {
+		cmd = `${cmd} ${ctx.framework.args.join(" ")}`;
+	}
+
 	endSection(
 		`Continue with ${ctx.framework?.config.displayName}`,
 		`via \`${cmd.trim()}\``

packages/create-cloudflare/src/pages.ts

@@ -46,6 +46,7 @@ export const runPagesGenerator = async (args: C3Args) => {
 				...defaultFrameworkConfig,
 				...frameworkConfig,
 			},
+			args: args.additionalArgs ?? [],
 		},
 		args,
 		type: frameworkConfig.type,

packages/create-cloudflare/src/types.ts

@@ -15,6 +15,7 @@ export type C3Args = {
 	existingScript?: string;
 	wranglerDefaults?: boolean;
 	acceptDefaults?: boolean;
+	additionalArgs?: string[];
 };
 
 export type C3Arg = C3Args[keyof C3Args];
@@ -29,6 +30,7 @@ export type PagesGeneratorContext = {
 	framework?: {
 		name: string;
 		config: FrameworkConfig;
+		args: string[];
 		commitMessage?: string;
 	};
 	project: {