Skip to content

Commit

Permalink
use exposed url+inspectorUrl
Browse files Browse the repository at this point in the history
  • Loading branch information
RamIdeas committed Jun 27, 2024
1 parent dfd9315 commit 1079c6d
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions packages/wrangler/src/dev.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { validateNodeCompat } from "./deployment-bundle/node-compat";
import Dev from "./dev/dev";
import { getVarsForDev } from "./dev/dev-vars";
import { getLocalPersistencePath } from "./dev/get-local-persistence-path";
import { openInspector } from "./dev/inspect";
import { maybeRegisterLocalWorker } from "./dev/local";
import { startDevServer } from "./dev/start-server";
import { UserError } from "./errors";
Expand Down Expand Up @@ -514,17 +515,21 @@ export async function startDev(args: StartDevOptions) {
keys: ["b"],
label: "open a browser",
handler: async () => {
const { proxyWorker } = await devEnv.proxy.ready.promise;
const url = await proxyWorker.ready; // TODO: get url from line above when https://github.com/cloudflare/workers-sdk/pull/6124 is merged
const { url } = await devEnv.proxy.ready.promise;
await openInBrowser(url.href);
},
},
{
keys: ["d"],
label: "open devtools",
handler: async () => {
// TODO: get inspector url like above when https://github.com/cloudflare/workers-sdk/pull/6124 is merged
// await openInspector(port, props.worker);
const { inspectorUrl } = await devEnv.proxy.ready.promise;

// TODO: refactor this function to accept a whole URL and not assume hostname
await openInspector(
parseInt(inspectorUrl.port),
devEnv.config.latestConfig?.name // TODO: this will be set once readConfig is moved into ConfigController in DEVX-1295
);
},
},
{
Expand Down

0 comments on commit 1079c6d

Please sign in to comment.