Fix: Avoid unnecessary rebuilding pages functions in wrangler pages d…

…ev (#3311)
cloudflare · Jun 5, 2023 · 116d3fd · 116d3fd
1 parent b5b46b4
commit 116d3fd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/cuddly-weeks-behave.md b/.changeset/cuddly-weeks-behave.md
@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Fix: Avoid unnecessary rebuilding pages functions in wrangler pages dev
diff --git a/packages/wrangler/src/pages/build.ts b/packages/wrangler/src/pages/build.ts
@@ -150,6 +150,8 @@ export const Handler = async (args: PagesBuildArgs) => {
 				minify,
 				sourcemap,
 				fallbackService,
+				// This only watches already existing files using the esbuild watching mechanism
+				// it will not watch new files that are added to the functions directory!
 				watch,
 				plugin,
 				legacyNodeCompat,

diff --git a/packages/wrangler/src/pages/dev.ts b/packages/wrangler/src/pages/dev.ts
@@ -298,7 +298,7 @@ export const Handler = async ({
 						nodejsCompat,
 						local: true,
 						sourcemap: true,
-						watch: true,
+						watch: false,
 						onEnd: () => scriptReadyResolve(),
 					});
 				} catch (e: unknown) {
@@ -339,7 +339,7 @@ export const Handler = async ({
 					outfile: scriptPath,
 					functionsDirectory,
 					sourcemap: true,
-					watch: true,
+					watch: false,
 					onEnd,
 					buildOutputDirectory: directory,
 					legacyNodeCompat,