Skip to content

Commit

Permalink
Upgrade ESLint & TurboRepo (#3974)
Browse files Browse the repository at this point in the history
* Upgrade ESLint & TurboRepo
ESLint has some decent upgrades, which include being more sensitive to TypeScript. This also meant a peer dependency was needed @typescript-eslint/eslint-plugin.
Additionally a TurboRepo upgrade was added due to little overhead and no code changes needed.
  • Loading branch information
JacobMGEvans authored Sep 19, 2023
1 parent 291c78b commit 37f8731
Show file tree
Hide file tree
Showing 4 changed files with 421 additions and 150 deletions.
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@
"@changesets/changelog-github": "^0.4.5",
"@changesets/cli": "^2.22.0",
"@types/node": "^20.0.0",
"@typescript-eslint/eslint-plugin": "^5.59.9",
"@typescript-eslint/parser": "^5.59.9",
"cross-env": "^7.0.3",
"esbuild-register": "^3.5.0",
"ioredis": "^4.28.2",
Expand All @@ -46,7 +44,7 @@
"@turbo/gen": "^1.10.13",
"dotenv-cli": "^7.3.0",
"esbuild": "0.17.19",
"turbo": "^1.10.13"
"turbo": "^1.10.14"
},
"engines": {
"node": ">=16.13.0"
Expand Down
10 changes: 7 additions & 3 deletions packages/eslint-config-worker/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,16 @@
"description": "ESLint config for workers-sdk",
"main": "index.js",
"dependencies": {
"eslint": "^8.42.0",
"@typescript-eslint/parser": "^6.7.2",
"eslint": "^8.49.0",
"eslint-config-turbo": "latest",
"eslint-plugin-import": "2.26.x",
"eslint-plugin-no-only-tests": "^3.1.0",
"eslint-plugin-react": "^7.32.2",
"eslint-plugin-react": "^7.33.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-unused-imports": "^2.0.0"
"eslint-plugin-unused-imports": "^3.0.0"
},
"peerDependencies": {
"@typescript-eslint/eslint-plugin": "^6.7.2"
}
}
2 changes: 1 addition & 1 deletion packages/wrangler/src/dev/miniflare.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export interface ConfigBundle {
localProtocol: "http" | "https";
localUpstream: string | undefined;
inspect: boolean;
serviceBindings: Record<string, (request: Request) => Promise<Response>>;
serviceBindings: Record<string, (_request: Request) => Promise<Response>>;
}

class WranglerLog extends Log {
Expand Down
Loading

0 comments on commit 37f8731

Please sign in to comment.