Skip to content

Commit

Permalink
chore: remove the warning about local mode flag being removed in the …
Browse files Browse the repository at this point in the history
…future
  • Loading branch information
threepointone committed Aug 23, 2024
1 parent 419e9f0 commit 39e0e87
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 28 deletions.
5 changes: 5 additions & 0 deletions .changeset/clean-rockets-decide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

chore: remove the warning about local mode flag being removed in the future
7 changes: 0 additions & 7 deletions fixtures/pages-functions-app/tests/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,6 @@ describe("Pages Functions", () => {
expect(text).toContain("<h1>An asset</h1>");
});

it("doesn't warn about local mode", async ({ expect }) => {
// Regression test for https://github.com/cloudflare/workers-sdk/issues/4210
expect(getOutput()).not.toContain(
"--local is no longer required and will be removed in a future version"
);
});

describe("can mount a plugin", () => {
it("should mount Middleware", async ({ expect }) => {
const response = await fetch(
Expand Down
3 changes: 0 additions & 3 deletions packages/wrangler/e2e/pages-dev.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ describe.each([
const { url } = await worker.waitForReady();
const text = await fetchText(url);
expect(text).toBe("Testing [--experimental-local]");
expect(await worker.currentOutput).toContain(
`--experimental-local is no longer required and will be removed in a future version`
);
});

it("should show [--service] related warnings if specified as arg in the command line", async () => {
Expand Down
12 changes: 0 additions & 12 deletions packages/wrangler/src/dev.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -557,18 +557,6 @@ export async function startDev(args: StartDevOptions) {
logger.loggerLevel = args.logLevel;
}

if (args.local) {
logger.warn(
"--local is no longer required and will be removed in a future version.\n`wrangler dev` now uses the local Cloudflare Workers runtime by default. 🎉"
);
}

if (args.experimentalLocal) {
logger.warn(
"--experimental-local is no longer required and will be removed in a future version.\n`wrangler dev` now uses the local Cloudflare Workers runtime by default. 🎉"
);
}

if (args.inspect) {
//devtools are enabled by default, but we still need to disable them if the caller doesn't want them
logger.warn(
Expand Down
6 changes: 0 additions & 6 deletions packages/wrangler/src/pages/dev.ts
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,6 @@ export const Handler = async (args: PagesDevArguments) => {

await printWranglerBanner();

if (args.experimentalLocal) {
logger.warn(
"--experimental-local is no longer required and will be removed in a future version.\n`wrangler pages dev` now uses the local Cloudflare Workers runtime by default."
);
}

if (args.config) {
throw new FatalError(
"Pages does not support custom paths for the `wrangler.toml` configuration file",
Expand Down

0 comments on commit 39e0e87

Please sign in to comment.