Remove _serveAssetsFromWorker

cloudflare · Jun 10, 2024 · 6dd781b · 6dd781b
1 parent d0027f4
commit 6dd781b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/wrangler/src/api/startDevWorker/BundlerController.ts b/packages/wrangler/src/api/startDevWorker/BundlerController.ts
@@ -103,7 +103,9 @@ export class BundlerController extends Controller<BundlerControllerEventMap> {
 						bundle: true,
 						additionalModules: [],
 						moduleCollector,
-						serveAssetsFromWorker: Boolean(config._serveAssetsFromWorker),
+						serveAssetsFromWorker: Boolean(
+							config.legacy?.assets && !config.dev?.remote
+						),
 						doBindings: config._bindings?.durable_objects?.bindings ?? [],
 						jsxFactory: config.build.jsxFactory,
 						jsxFragment: config.build.jsxFactory,
@@ -210,7 +212,9 @@ export class BundlerController extends Controller<BundlerControllerEventMap> {
 				additionalModules: config._additionalModules,
 				rules: config.build.moduleRules,
 				assets: config.legacy?.assets,
-				serveAssetsFromWorker: Boolean(config._serveAssetsFromWorker),
+				serveAssetsFromWorker: Boolean(
+					config.legacy?.assets && !config.dev?.remote
+				),
 				tsconfig: config.build?.tsconfig,
 				minify: config.build?.minify,
 				nodejsCompatMode: config.build.nodejsCompatMode,

diff --git a/packages/wrangler/src/api/startDevWorker/types.ts b/packages/wrangler/src/api/startDevWorker/types.ts
@@ -78,7 +78,6 @@ export interface InputStartDevWorkerOptions {
 	sendMetrics?: boolean;
 	usageModel?: "bundled" | "unbound";
 	_bindings?: CfWorkerInit["bindings"]; // Type level constraint for bindings not sharing names
-	_serveAssetsFromWorker?: boolean;
 	_processEntrypoint?: boolean;
 	_additionalModules?: CfModule[];
 	// --/ PASSTHROUGH --

diff --git a/packages/wrangler/src/dev/dev.tsx b/packages/wrangler/src/dev/dev.tsx
@@ -382,9 +382,6 @@ function DevSession(props: DevSessionProps) {
 			script: { path: props.entry.file },
 			directory: props.entry.directory,
 			_bindings: props.bindings,
-			_serveAssetsFromWorker: Boolean(
-				props.assetPaths && !props.isWorkersSite && props.local
-			),
 			_processEntrypoint: props.processEntrypoint,
 			_additionalModules: props.additionalModules,