VS-271: Fix Vectorize getVcetors, deleteVectors payload in Wrangler C…

…lient
cloudflare · Aug 21, 2024 · b36ac37 · b36ac37
1 parent fc3636b
commit b36ac37
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 4 deletions.
diff --git a/packages/wrangler/src/vectorize/client.ts b/packages/wrangler/src/vectorize/client.ts
@@ -12,6 +12,7 @@ import type {
 	VectorizeMetadataIndexPropertyName,
 	VectorizeQueryOptions,
 	VectorizeVector,
+	VectorizeVectorIds,
 	VectorizeVectorMutation,
 } from "./types";
 import type { FormData } from "undici";
@@ -155,7 +156,7 @@ export async function queryIndex(
 export async function getByIds(
 	config: Config,
 	indexName: string,
-	ids: Array<string>
+	ids: VectorizeVectorIds
 ): Promise<VectorizeVector[]> {
 	const accountId = await requireAuth(config);
 
@@ -174,7 +175,7 @@ export async function getByIds(
 export async function deleteByIds(
 	config: Config,
 	indexName: string,
-	ids: Array<string>
+	ids: VectorizeVectorIds
 ): Promise<VectorizeAsyncMutation> {
 	const accountId = await requireAuth(config);
 

diff --git a/packages/wrangler/src/vectorize/deleteByIds.ts b/packages/wrangler/src/vectorize/deleteByIds.ts
@@ -6,6 +6,7 @@ import type {
 	CommonYargsArgv,
 	StrictYargsOptionsToInterface,
 } from "../yargs-types";
+import type { VectorizeVectorIds } from "./types";
 
 export function options(yargs: CommonYargsArgv) {
 	return yargs
@@ -37,7 +38,12 @@ export async function handler(
 	}
 
 	logger.log(`📋 Deleting vectors...`);
-	const mutation = await deleteByIds(config, args.name, args.ids);
+
+	const ids: VectorizeVectorIds = {
+		ids: args.ids,
+	};
+
+	const mutation = await deleteByIds(config, args.name, ids);
 
 	logger.log(
 		`✅ Successfully enqueued ${args.ids.length} vectors into index '${args.name}' for deletion. Mutation changeset identifier: ${mutation.mutationId}.`

diff --git a/packages/wrangler/src/vectorize/getByIds.ts b/packages/wrangler/src/vectorize/getByIds.ts
@@ -6,6 +6,7 @@ import type {
 	CommonYargsArgv,
 	StrictYargsOptionsToInterface,
 } from "../yargs-types";
+import type { VectorizeVectorIds } from "./types";
 
 export function options(yargs: CommonYargsArgv) {
 	return yargs
@@ -37,7 +38,12 @@ export async function handler(
 	}
 
 	logger.log(`📋 Fetching vectors...`);
-	const vectors = await getByIds(config, args.name, args.ids);
+
+	const ids: VectorizeVectorIds = {
+		ids: args.ids,
+	};
+
+	const vectors = await getByIds(config, args.name, ids);
 
 	if (vectors.length === 0) {
 		logger.warn(

diff --git a/packages/wrangler/src/vectorize/types.ts b/packages/wrangler/src/vectorize/types.ts
@@ -138,6 +138,14 @@ export interface VectorizeVectorMutation {
 	count: number;
 }
 
+/**
+ * Request type used to pass vector ids to fetch or delete.
+ */
+export interface VectorizeVectorIds {
+	/* List of vector ids that are fetched or deleted. */
+	ids: string[];
+}
+
 /**
  * Result type indicating a mutation on the Vectorize Index.
  * Actual mutations are processed async where the `mutationId` is the unique identifier for the operation.