Bump miniflare version to 20231023 (#4274)

* Bump miniflare version to 20231023

* chore: bump `miniflare` to `3.20231025.0`

* Try to improve reliability of `pages-plugin-mounted-on-root-app` test

---------

Co-authored-by: bcoll <bcoll@cloudflare.com>

.changeset/good-beers-design.md

@@ -0,0 +1,9 @@
+---
+"wrangler": patch
+---
+
+chore: bump `miniflare` to [`3.20231025.0`](https://github.com/cloudflare/miniflare/releases/tag/v3.20231025.0)
+
+This change enables Node-like `console.log()`ing in local mode. Objects with
+lots of properties, and instances of internal classes like `Request`, `Headers`,
+`ReadableStream`, etc will now be logged with much more detail.

fixtures/pages-plugin-mounted-on-root-app/tests/index.test.ts

@@ -1,43 +1,23 @@
-import { fork } from "child_process";
 import * as path from "path";
 import { fetch } from "undici";
 import { describe, it, beforeAll, afterAll } from "vitest";
-import type { ChildProcess } from "child_process";
+import { runWranglerPagesDev } from "../../shared/src/run-wrangler-long-lived";
 
 describe("Pages Functions", () => {
-	let wranglerProcess: ChildProcess;
 	let ip: string;
 	let port: number;
+	let stop: (() => Promise<unknown>) | undefined;
 
 	beforeAll(async () => {
-		await new Promise((resolve) => {
-			wranglerProcess = fork(
-				path.join("..", "..", "packages", "wrangler", "bin", "wrangler.js"),
-				["pages", "dev", "public", "--port=0"],
-				{
-					stdio: ["ignore", "ignore", "ignore", "ipc"],
-					cwd: path.resolve(__dirname, ".."),
-				}
-			).on("message", (message) => {
-				const parsedMessage = JSON.parse(message.toString());
-				ip = parsedMessage.ip;
-				port = parsedMessage.port;
-				resolve(null);
-			});
-		});
+		({ ip, port, stop } = await runWranglerPagesDev(
+			path.resolve(__dirname, ".."),
+			"public",
+			["--port=0"]
+		));
 	});
 
 	afterAll(async () => {
-		await new Promise((resolve, reject) => {
-			wranglerProcess.once("exit", (code) => {
-				if (!code) {
-					resolve(code);
-				} else {
-					reject(code);
-				}
-			});
-			wranglerProcess.kill("SIGTERM");
-		});
+		await stop?.();
 	});
 
 	it("mounts a plugin correctly at root", async ({ expect }) => {

fixtures/pages-ws-app/package.json

@@ -16,7 +16,7 @@
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",
-		"miniflare": "3.20231016.0",
+		"miniflare": "3.20231025.0",
 		"wrangler": "workspace:*",
 		"ws": "^8.8.0"
 	},

packages/pages-shared/package.json

@@ -18,7 +18,7 @@
 		"test:ci": "vitest run"
 	},
 	"dependencies": {
-		"miniflare": "3.20231016.0"
+		"miniflare": "3.20231025.0"
 	},
 	"devDependencies": {
 		"@cloudflare/workers-tsconfig": "workspace:*",

packages/wrangler/package.json

@@ -107,7 +107,7 @@
 		"blake3-wasm": "^2.1.5",
 		"chokidar": "^3.5.3",
 		"esbuild": "0.17.19",
-		"miniflare": "3.20231016.0",
+		"miniflare": "3.20231025.0",
 		"nanoid": "^3.3.3",
 		"path-to-regexp": "^6.2.0",
 		"resolve.exports": "^2.0.2",

packages/wrangler/src/dev/local.tsx

@@ -133,7 +133,7 @@ export function Local(props: LocalProps) {
 	useInspector({
 		inspectorUrl,
 		port: props.inspectorPort,
-		logToTerminal: true,
+		logToTerminal: false,
 		sourceMapPath: props.sourceMapPath,
 		name: props.name,
 		sourceMapMetadata: props.bundle?.sourceMapMetadata,