debug windows

cloudflare · Jul 1, 2024 · c91197e · c91197e
1 parent 34b2926
commit c91197e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 88 deletions.
diff --git a/packages/wrangler/e2e/pages-dev.test.ts b/packages/wrangler/e2e/pages-dev.test.ts
@@ -134,38 +134,6 @@ describe("pages dev", () => {
 		);
 	});
 
-	it("should modify worker during dev session (Functions)", async () => {
-		const helper = new WranglerE2ETestHelper();
-		const port = await getPort();
-		const worker = helper.runLongLived(`wrangler pages dev --port ${port} .`);
-
-		await helper.seed({
-			"functions/_middleware.js": dedent`
-					export async function onRequest() {
-						return new Response("Hello World!")
-					}`,
-		});
-
-		const { url } = await worker.waitForReady();
-
-		await expect(
-			fetch(url).then((r) => r.text())
-		).resolves.toMatchInlineSnapshot('"Hello World!"');
-
-		await helper.seed({
-			"functions/_middleware.js": dedent`
-					export async function onRequest() {
-						return new Response("Updated Worker!")
-					}`,
-		});
-
-		await worker.waitForReload();
-
-		await expect(
-			fetch(url).then((r) => r.text())
-		).resolves.toMatchInlineSnapshot('"Updated Worker!"');
-	});
-
 	it("should support wrangler.toml", async () => {
 		const helper = new WranglerE2ETestHelper();
 		await helper.seed({
@@ -282,61 +250,6 @@ describe("pages dev", () => {
 		).resolves.toMatchInlineSnapshot('"Updated Worker!"');
 	});
 
-	it("should support modifying _routes.json during dev session", async () => {
-		const helper = new WranglerE2ETestHelper();
-		await helper.seed({
-			"_worker.js": dedent`
-					export default {
-						async fetch(request, env) {
-							const url = new URL(request.url);
-							if (url.pathname === "/foo") {
-								return new Response("foo");
-							}
-							if (url.pathname === "/bar") {
-								return new Response("bar");
-							}
-							return new Response("Hello _routes.json")
-						}
-					}`,
-			"_routes.json": dedent`
-				{
-					"version": 1,
-					"include": ["/foo", "/bar"],
-					"exclude": []
-				}
-			`,
-			"index.html": dedent`
-				hello world
-			`,
-		});
-		const port = await getPort();
-		const worker = helper.runLongLived(`wrangler pages dev --port ${port} .`);
-		const { url } = await worker.waitForReady();
-
-		const foo = await fetchText(`${url}/foo`);
-		expect(foo).toMatchInlineSnapshot('"foo"');
-
-		const bar = await fetchText(`${url}/bar`);
-		expect(bar).toMatchInlineSnapshot('"bar"');
-
-		await helper.seed({
-			"_routes.json": dedent`
-				{
-					"version": 1,
-					"include": ["/foo"],
-					"exclude": ["/bar"]
-				}
-			`,
-		});
-		await worker.waitForReload();
-
-		const foo2 = await fetchText(`${url}/foo`);
-		expect(foo2).toMatchInlineSnapshot('"foo"');
-
-		const bar2 = await fetchText(`${url}/bar`);
-		expect(bar2).toMatchInlineSnapshot('"hello world"');
-	});
-
 	it("should validate _routes.json during dev session, and fallback to default value", async () => {
 		const helper = new WranglerE2ETestHelper();
 		await helper.seed({

diff --git a/packages/wrangler/src/pages/dev.ts b/packages/wrangler/src/pages/dev.ts
@@ -524,6 +524,8 @@ export const Handler = async (args: PagesDevArguments) => {
 
 				for (const dep in bundle.dependencies) {
 					const resolvedDep = resolve(functionsDirectory, dep);
+
+					logger.log("RESOLVED_DEP", resolvedDep);
 					/*
 					 * EXCLUDE:
 					 *   - the "/functions" directory because we're already watching it

diff --git a/packages/wrangler/src/pages/functions/buildWorker.ts b/packages/wrangler/src/pages/functions/buildWorker.ts
@@ -351,7 +351,7 @@ export function buildNotifierPlugin(onEnd: () => void): Plugin {
 		name: "wrangler notifier and monitor",
 		setup(pluginBuild) {
 			pluginBuild.onEnd((result) => {
-				if(result.errors.length > 0 || result.warnings.length > 0) {
+				if (result.errors.length > 0 || result.warnings.length > 0) {
 					logBuildFailure(result.errors, result.warnings);
 				} else {
 					logger.log("✨ Compiled Worker successfully");