chore: remove d1 local hardcoding (#2248)

* chore: remove d1 local hardcoding * Create tall-waves-film.md
cloudflare · Nov 21, 2022 · effc221 · effc221
1 parent ef24dba
commit effc221
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/tall-waves-film.md b/.changeset/tall-waves-film.md
@@ -0,0 +1,9 @@
+---
+"wrangler": patch
+---
+
+chore: remove d1 local hardcoding
+
+Prior to this change wrangler would only ever use local mode when testing d1.
+
+After this change d1 tests can access both local and remote Workers.
diff --git a/packages/wrangler/src/dev/start-server.ts b/packages/wrangler/src/dev/start-server.ts
@@ -99,6 +99,7 @@ export async function startDevServer(
 			services: props.bindings.services,
 			firstPartyWorkerDevFacade: props.firstPartyWorker,
 			testScheduled: props.testScheduled,
+			local: props.local,
 		});
 
 		if (props.local) {
@@ -206,6 +207,7 @@ async function runEsbuild({
 	services,
 	firstPartyWorkerDevFacade,
 	testScheduled,
+	local,
 }: {
 	entry: Entry;
 	destination: string | undefined;
@@ -224,6 +226,7 @@ async function runEsbuild({
 	workerDefinitions: WorkerRegistry;
 	firstPartyWorkerDevFacade: boolean | undefined;
 	testScheduled?: boolean;
+	local: boolean;
 }): Promise<EsbuildBundle | undefined> {
 	if (!destination) return;
 
@@ -262,7 +265,7 @@ async function runEsbuild({
 				services,
 				firstPartyWorkerDevFacade,
 				targetConsumer: "dev", // We are starting a dev server
-				local: true,
+				local,
 				testScheduled,
 		  });