[D1] fix batch splitting to handle CASE as compound statement starts (#…

…4951)

* fix: add CASE to compound statement starts

* chore: add changeset

* chore: cleanup and add tests

* chore: improve test coverage

* chore: delete leftover file

* chore: add missed commit

* Update packages/wrangler/src/d1/splitter.ts

Co-authored-by: Max Rozen <3822106+rozenmd@users.noreply.github.com>

---------

Co-authored-by: Max Rozen <3822106+rozenmd@users.noreply.github.com>

.changeset/cyan-kiwis-return.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+fix: D1 batch splitting to handle CASE as compound statement starts

packages/wrangler/src/__tests__/d1/splitter.test.ts

@@ -241,7 +241,7 @@ describe("splitSqlQuery()", () => {
 	`);
 	});
 
-	it("should handle compound statements", () => {
+	it("should handle compound statements for BEGINs", () => {
 		expect(
 			splitSqlQuery(`
     CREATE TRIGGER IF NOT EXISTS update_trigger AFTER UPDATE ON items
@@ -275,4 +275,50 @@ describe("splitSqlQuery()", () => {
 		]
 	`);
 	});
+
+	it("should handle compound statements for CASEs", () => {
+		expect(
+			splitSqlQuery(`
+				CREATE TRIGGER test_after_insert_trigger AFTER
+				INSERT ON test BEGIN
+				SELECT CASE
+						WHEN NOT EXISTS
+									(SELECT 1
+										FROM pragma_table_list(new."table")) THEN RAISE (
+																																		ABORT,
+																																		'Exception, table does not exist')
+				END ; END ;
+
+				CREATE TRIGGER test_after_insert_trigger AFTER
+				INSERT ON test BEGIN
+				SELECT CASE
+						WHEN NOT EXISTS
+									(SELECT 1
+										FROM pragma_table_list(new."table")) THEN RAISE (
+																																		ABORT,
+																																		'Exception, table does not exist')
+				END ; END ;`)
+		).toMatchInlineSnapshot(`
+		Array [
+		  "CREATE TRIGGER test_after_insert_trigger AFTER
+						INSERT ON test BEGIN
+						SELECT CASE
+								WHEN NOT EXISTS
+											(SELECT 1
+												FROM pragma_table_list(new.\\"table\\")) THEN RAISE (
+																																				ABORT,
+																																				'Exception, table does not exist')
+						END ; END",
+		  "CREATE TRIGGER test_after_insert_trigger AFTER
+						INSERT ON test BEGIN
+						SELECT CASE
+								WHEN NOT EXISTS
+											(SELECT 1
+												FROM pragma_table_list(new.\\"table\\")) THEN RAISE (
+																																				ABORT,
+																																				'Exception, table does not exist')
+						END ; END",
+		]
+	`);
+	});
 });

packages/wrangler/src/d1/splitter.ts

@@ -150,10 +150,10 @@ function isDollarQuoteIdentifier(str: string) {
 }
 
 /**
- * Returns true if the `str` ends with a compound statement `BEGIN` marker.
+ * Returns true if the `str` ends with a compound statement `BEGIN` or `CASE` marker.
  */
 function isCompoundStatementStart(str: string) {
-	return /\sBEGIN\s$/.test(str);
+	return /\s(BEGIN|CASE)\s$/.test(str);
 }
 
 /**