-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrangler dev with durable object configured in wrangler.toml fails in miniflare #172
Comments
You should file this issue under the miniflare repo |
oh wait, you're saying you tried this with |
can confirm I'm seeing the same thing. Here's an example of the args passed to it - [
'--experimental-vm-modules',
'--inspect',
'/Users/threepointone/code/testdo/node_modules/miniflare/dist/src/cli.js',
'../../../../../../var/folders/cq/w4qlzy2d4v924d23r3yj7pk00000gn/T/tmp-26115-fSWD0vwV1mxV/server.js',
'--watch',
'--wrangler-config',
'/Users/threepointone/code/testdo/node_modules/wrangler/miniflare-config-stubs/wrangler.empty.toml',
'--env',
'/Users/threepointone/code/testdo/node_modules/wrangler/miniflare-config-stubs/.env.empty',
'--package',
'/Users/threepointone/code/testdo/node_modules/wrangler/miniflare-config-stubs/package.empty.json',
'--port',
'8787',
'--kv-persist',
'--cache-persist',
'--do-persist',
'--do DurableClass=DurableClass',
'--modules',
'true'
] |
Potentially because |
Ok that's probably it, I should've separated it out. Thanks! |
When calling miniflare in `dev` the bindings are passed into the process that's spawned incorrectly; each arg needs to be a separate element in the args array to the spawn call. This PR fixes how they're added to the args array. It also enables logs on the miniflare process. (they're a bit noisy, but we can make that better separately.) I'm personally annoyed because I can swear this was working previously, but without tests that's just my word against... my own word, lol. fixes #172
* pass bindings correctly to miniflare in `dev` When calling miniflare in `dev` the bindings are passed into the process that's spawned incorrectly; each arg needs to be a separate element in the args array to the spawn call. This PR fixes how they're added to the args array. It also enables logs on the miniflare process. (they're a bit noisy, but we can make that better separately.) I'm personally annoyed because I can swear this was working previously, but without tests that's just my word against... my own word, lol. fixes #172 * add a changeset
This is fixed in the repo, but we have a bug where alphas aren't being published to npm on every commit right now (fix in #175). Once that lands, you can use |
I think the class name is not being passed, eg. from miniflare docs:
This is my wrangler.toml file:
Tried to debug the command running with miniflare:
The text was updated successfully, but these errors were encountered: