Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache some calls in node_modules/.cache (specifically - account selection, but maybe more) #300

Closed
Tracked by #12
petebacondarwin opened this issue Jan 25, 2022 · 3 comments · Fixed by #1395 or #1336
Closed
Tracked by #12

cache some calls in node_modules/.cache (specifically - account selection, but maybe more) #300

petebacondarwin opened this issue Jan 25, 2022 · 3 comments · Fixed by #1395 or #1336
Assignees
@threepointone
Labels
maintenance Maintenance task

Comments

@petebacondarwin
Copy link
Contributor

No description provided.

@petebacondarwin petebacondarwin mentioned this issue Jan 25, 2022
Closed
27 tasks
@petebacondarwin petebacondarwin moved this to Non-blocking in workers-sdk Jan 25, 2022
@Electroid Electroid added the maintenance Maintenance task label Jan 25, 2022
@petebacondarwin petebacondarwin added this to the Wrangler 2.0 milestone Feb 1, 2022
@Electroid Electroid modified the milestones: 2.0, 2.1 Feb 22, 2022
@petebacondarwin petebacondarwin modified the milestones: Selected for development, Backlog May 15, 2022
@petebacondarwin petebacondarwin moved this to Backlog in workers-sdk May 15, 2022
@petebacondarwin petebacondarwin removed this from the Backlog milestone May 15, 2022
@petebacondarwin petebacondarwin moved this from Backlog to Selected for development in workers-sdk May 16, 2022
@threepointone
Copy link
Contributor

Assigning to myself so I remember to bring this up in our team meeting

@threepointone threepointone self-assigned this Jun 14, 2022
@petebacondarwin
Copy link
Contributor Author

Assigning to myself so I remember to bring this up in our team meeting

Added to the agenda.

@threepointone threepointone removed their assignment Jun 20, 2022
@threepointone
Copy link
Contributor

Unassigning now that we discussed it.

@threepointone threepointone self-assigned this Jul 3, 2022
threepointone added a commit that referenced this issue Jul 3, 2022
@threepointone
feat: cache account id selection
b5a1f14 
This adds caching for account id fetch/selection for all wrangler commands.

Currently, if we have an api/ouath token, but haven't provided an account id, we fetch account information from cloudflare. If a user has just one account id, we automatically choose that. If there are more than one, then we show a dropdown and ask the user to pick one. This is convenient, and lets the user not have to specify their account id when starting a project.

However, if does make startup slow, since it has to do that fetch every time. It's also annoying for folks with multiple account ids because they have to pick their account id every time.

So we now cache the account_id into `node_modules/.cache/wrangler` (much like pages already does with account id and project name).

This patch also refactors `config-cache.ts`; it only caches if there's a `node_modules` folder, and it looks for the closest node_modules folder (and not directly in cwd). I also added tests for when a `node_modules` folder isn't available. It also trims the message that we log to terminal.

Closes #300
threepointone added a commit that referenced this issue Jul 3, 2022
@threepointone
feat: cache account id selection
49a76e1 
This adds caching for account id fetch/selection for all wrangler commands.

Currently, if we have an api/ouath token, but haven't provided an account id, we fetch account information from cloudflare. If a user has just one account id, we automatically choose that. If there are more than one, then we show a dropdown and ask the user to pick one. This is convenient, and lets the user not have to specify their account id when starting a project.

However, if does make startup slow, since it has to do that fetch every time. It's also annoying for folks with multiple account ids because they have to pick their account id every time.

So we now cache the account_id into `node_modules/.cache/wrangler` (much like pages already does with account id and project name).

This patch also refactors `config-cache.ts`; it only caches if there's a `node_modules` folder, and it looks for the closest node_modules folder (and not directly in cwd). I also added tests for when a `node_modules` folder isn't available. It also trims the message that we log to terminal.

Closes #300
threepointone added a commit that referenced this issue Jul 3, 2022
@threepointone
feat: cache account id selection
c2bec9d 
This adds caching for account id fetch/selection for all wrangler commands.

Currently, if we have an api/oauth token, but haven't provided an account id, we fetch account information from cloudflare. If a user has just one account id, we automatically choose that. If there are more than one, then we show a dropdown and ask the user to pick one. This is convenient, and lets the user not have to specify their account id when starting a project.

However, if does make startup slow, since it has to do that fetch every time. It's also annoying for folks with multiple account ids because they have to pick their account id every time.

So we now cache the account_id into `node_modules/.cache/wrangler` (much like pages already does with account id and project name).

This patch also refactors `config-cache.ts`; it only caches if there's a `node_modules` folder, and it looks for the closest node_modules folder (and not directly in cwd). I also added tests for when a `node_modules` folder isn't available. It also trims the message that we log to terminal.

Closes #300
@threepointone threepointone mentioned this issue Jul 3, 2022
Merged
@petebacondarwin petebacondarwin moved this from Selected for development to In Progress in workers-sdk Jul 4, 2022
threepointone added a commit that referenced this issue Jul 4, 2022
@threepointone
feat: cache account id selection
bfab7d0 
This adds caching for account id fetch/selection for all wrangler commands.

Currently, if we have an api/oauth token, but haven't provided an account id, we fetch account information from cloudflare. If a user has just one account id, we automatically choose that. If there are more than one, then we show a dropdown and ask the user to pick one. This is convenient, and lets the user not have to specify their account id when starting a project.

However, if does make startup slow, since it has to do that fetch every time. It's also annoying for folks with multiple account ids because they have to pick their account id every time.

So we now cache the account_id into `node_modules/.cache/wrangler` (much like pages already does with account id and project name).

This patch also refactors `config-cache.ts`; it only caches if there's a `node_modules` folder, and it looks for the closest node_modules folder (and not directly in cwd). I also added tests for when a `node_modules` folder isn't available. It also trims the message that we log to terminal.

Closes #300
threepointone added a commit that referenced this issue Jul 4, 2022
@threepointone
feat: cache account id selection
336c2c7 
This adds caching for account id fetch/selection for all wrangler commands.

Currently, if we have an api/oauth token, but haven't provided an account id, we fetch account information from cloudflare. If a user has just one account id, we automatically choose that. If there are more than one, then we show a dropdown and ask the user to pick one. This is convenient, and lets the user not have to specify their account id when starting a project.

However, if does make startup slow, since it has to do that fetch every time. It's also annoying for folks with multiple account ids because they have to pick their account id every time.

So we now cache the account_id into `node_modules/.cache/wrangler` (much like pages already does with account id and project name).

This patch also refactors `config-cache.ts`; it only caches if there's a `node_modules` folder, and it looks for the closest node_modules folder (and not directly in cwd). I also added tests for when a `node_modules` folder isn't available. It also trims the message that we log to terminal.

Closes #300
threepointone added a commit that referenced this issue Jul 4, 2022
@threepointone
feat: cache account id selection
bb557b0 
This adds caching for account id fetch/selection for all wrangler commands.

Currently, if we have an api/oauth token, but haven't provided an account id, we fetch account information from cloudflare. If a user has just one account id, we automatically choose that. If there are more than one, then we show a dropdown and ask the user to pick one. This is convenient, and lets the user not have to specify their account id when starting a project.

However, if does make startup slow, since it has to do that fetch every time. It's also annoying for folks with multiple account ids because they have to pick their account id every time.

So we now cache the account details into `node_modules/.cache/wrangler` (much like pages already does with account id and project name).

This patch also refactors `config-cache.ts`; it only caches if there's a `node_modules` folder, and it looks for the closest node_modules folder (and not directly in cwd). I also added tests for when a `node_modules` folder isn't available. It also trims the message that we log to terminal.

Closes #300
threepointone added a commit that referenced this issue Jul 5, 2022
@threepointone
feat: cache account id selection
9b7e3b9 
This adds caching for account id fetch/selection for all wrangler commands.

Currently, if we have an api/oauth token, but haven't provided an account id, we fetch account information from cloudflare. If a user has just one account id, we automatically choose that. If there are more than one, then we show a dropdown and ask the user to pick one. This is convenient, and lets the user not have to specify their account id when starting a project.

However, if does make startup slow, since it has to do that fetch every time. It's also annoying for folks with multiple account ids because they have to pick their account id every time.

So we now cache the account details into `node_modules/.cache/wrangler` (much like pages already does with account id and project name).

This patch also refactors `config-cache.ts`; it only caches if there's a `node_modules` folder, and it looks for the closest node_modules folder (and not directly in cwd). I also added tests for when a `node_modules` folder isn't available. It also trims the message that we log to terminal.

Closes #300
threepointone added a commit that referenced this issue Jul 5, 2022
@threepointone
feat: cache account id selection (#1395)
88f2702 
This adds caching for account id fetch/selection for all wrangler commands.

Currently, if we have an api/oauth token, but haven't provided an account id, we fetch account information from cloudflare. If a user has just one account id, we automatically choose that. If there are more than one, then we show a dropdown and ask the user to pick one. This is convenient, and lets the user not have to specify their account id when starting a project.

However, if does make startup slow, since it has to do that fetch every time. It's also annoying for folks with multiple account ids because they have to pick their account id every time.

So we now cache the account details into `node_modules/.cache/wrangler` (much like pages already does with account id and project name).

This patch also refactors `config-cache.ts`; it only caches if there's a `node_modules` folder, and it looks for the closest node_modules folder (and not directly in cwd). I also added tests for when a `node_modules` folder isn't available. It also trims the message that we log to terminal.

Closes #300
Repository owner moved this from In Progress to Done in workers-sdk Jul 5, 2022
@github-actions github-actions bot mentioned this issue Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@threepointone threepointone

Labels
maintenance Maintenance task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: cache account id selection cloudflare/workers-sdk
Version Packages cloudflare/workers-sdk
3 participants
@petebacondarwin @threepointone @Electroid