Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Missing -e flag for --env #660

Closed
JacobMGEvans opened this issue Mar 21, 2022 · 0 comments · Fixed by #662
Closed

🐛 BUG: Missing -e flag for --env #660

JacobMGEvans opened this issue Mar 21, 2022 · 0 comments · Fixed by #662
Assignees

Comments

@JacobMGEvans
Copy link
Contributor

What version of Wrangler are you using?

0.0.22

What operating system are you using?

Mac

Describe the Bug

Should use alias -e to prevent scripts using Wrangler 1 from breaking when switching to Wrangler 2

@JacobMGEvans JacobMGEvans self-assigned this Mar 21, 2022
@JacobMGEvans JacobMGEvans changed the title 🐛 BUG: Missing -e flag for --environment 🐛 BUG: Missing -e flag for --env Mar 21, 2022
mrbbot added a commit that referenced this issue Oct 31, 2023
With cloudflare/workerd#710, `workerd` supports breakpoint debugging!
Support for this in Miniflare just worked, assuming you were using a
plain JavaScript worker, or you had inline source maps. `workerd`
doesn't know where workers are located on disk, it just knows files'
locations relative to each other. This means it's unable to resolve
locations of corresponding linked `.map` files in `sourceMappingURL`
comments.

Miniflare _does_ have this information though. This change detects
linked source maps and rewrites `sourceMappingURL` comments to `http`
URLs pointing to Miniflare's loopback server. This then looks for the
source map relative to the known on-disk source location. Source
maps' `sourceRoot` attributes are updated to ensure correct locations
are displayed in DevTools.

**This enables breakpoint debugging for compiled TypeScript with
linked source maps!** 🎉

Closes DEVX-872
mrbbot added a commit that referenced this issue Nov 1, 2023
With cloudflare/workerd#710, `workerd` supports breakpoint debugging!
Support for this in Miniflare just worked, assuming you were using a
plain JavaScript worker, or you had inline source maps. `workerd`
doesn't know where workers are located on disk, it just knows files'
locations relative to each other. This means it's unable to resolve
locations of corresponding linked `.map` files in `sourceMappingURL`
comments.

Miniflare _does_ have this information though. This change detects
linked source maps and rewrites `sourceMappingURL` comments to `http`
URLs pointing to Miniflare's loopback server. This then looks for the
source map relative to the known on-disk source location. Source
maps' `sourceRoot` attributes are updated to ensure correct locations
are displayed in DevTools.

**This enables breakpoint debugging for compiled TypeScript with
linked source maps!** 🎉

Closes DEVX-872
mrbbot added a commit that referenced this issue Nov 1, 2023
With cloudflare/workerd#710, `workerd` supports breakpoint debugging!
Support for this in Miniflare just worked, assuming you were using a
plain JavaScript worker, or you had inline source maps. `workerd`
doesn't know where workers are located on disk, it just knows files'
locations relative to each other. This means it's unable to resolve
locations of corresponding linked `.map` files in `sourceMappingURL`
comments.

Miniflare _does_ have this information though. This change detects
linked source maps and rewrites `sourceMappingURL` comments to `http`
URLs pointing to Miniflare's loopback server. This then looks for the
source map relative to the known on-disk source location. Source
maps' `sourceRoot` attributes are updated to ensure correct locations
are displayed in DevTools.

**This enables breakpoint debugging for compiled TypeScript with
linked source maps!** 🎉

Closes DEVX-872
mrbbot added a commit that referenced this issue Nov 1, 2023
With cloudflare/workerd#710, `workerd` supports breakpoint debugging!
Support for this in Miniflare just worked, assuming you were using a
plain JavaScript worker, or you had inline source maps. `workerd`
doesn't know where workers are located on disk, it just knows files'
locations relative to each other. This means it's unable to resolve
locations of corresponding linked `.map` files in `sourceMappingURL`
comments.

Miniflare _does_ have this information though. This change detects
linked source maps and rewrites `sourceMappingURL` comments to `http`
URLs pointing to Miniflare's loopback server. This then looks for the
source map relative to the known on-disk source location. Source
maps' `sourceRoot` attributes are updated to ensure correct locations
are displayed in DevTools.

**This enables breakpoint debugging for compiled TypeScript with
linked source maps!** 🎉

Closes DEVX-872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant