Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error if running inside github actions without CLOUDFLARE_API_TOKEN #827

Closed
threepointone opened this issue Apr 20, 2022 · 0 comments · Fixed by #852 or #889
Closed

Throw an error if running inside github actions without CLOUDFLARE_API_TOKEN #827

threepointone opened this issue Apr 20, 2022 · 0 comments · Fixed by #852 or #889
Assignees
@JacobMGEvans

Comments

@threepointone
Copy link
Contributor

threepointone commented Apr 20, 2022 •
edited
Loading

We should detect when we're running inside github actions (or any other CI?) and have a good clear error that one should use CLOUDFLARE_API_TOKEN in such an environment (if it's missing). Similarly if CLOUDFLARE_ACCOUNT_ID is missing (but not if it's in wrangler.toml as account_id, of course
@threepointone threepointone moved this to Should-have in workers-sdk Apr 20, 2022
@threepointone threepointone added this to the 2.0 milestone Apr 20, 2022
@Electroid Electroid changed the title Throw an error if running inside github actions with CLOUDFLARE_API_TOKEN Throw an error if running inside github actions without CLOUDFLARE_API_TOKEN Apr 20, 2022
@JacobMGEvans JacobMGEvans mentioned this issue Apr 22, 2022
Closed
@JacobMGEvans JacobMGEvans self-assigned this Apr 22, 2022
JacobMGEvans added a commit that referenced this issue Apr 26, 2022
@JacobMGEvans
Added a check in CI/CD environments for account_id, `CLOUDFLARE_ACC…
06f5e6d 
…OUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`

then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
@JacobMGEvans JacobMGEvans mentioned this issue Apr 26, 2022
Merged
JacobMGEvans added a commit that referenced this issue Apr 26, 2022
@JacobMGEvans
CI/CD necessary variable checks:
607b433 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 26, 2022
@JacobMGEvans
CI/CD necessary variable checks:
927fa20 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 26, 2022
@JacobMGEvans
CI/CD necessary variable checks:
f3f6e6c 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 26, 2022
@JacobMGEvans
CI/CD necessary variable checks:
c071245 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 26, 2022
@JacobMGEvans
CI/CD necessary variable checks:
1ab1306 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 26, 2022
@JacobMGEvans
CI/CD necessary variable checks:
afa1b39 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 26, 2022
@JacobMGEvans
CI/CD necessary variable checks:
27c024a 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 27, 2022
@JacobMGEvans
CI/CD check for required variables:
1adc237 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 27, 2022
@JacobMGEvans
CI/CD check for required variables:
2413b3c 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 27, 2022
@JacobMGEvans
CI/CD check for required variables:
87cb0d2 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 27, 2022
@JacobMGEvans
CI/CD check for required variables:
7e63bd5 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 28, 2022
@JacobMGEvans
CI/CD check for required variables:
2c68c68 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 28, 2022
@JacobMGEvans
CI/CD check for required variables:
0989a0f 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 28, 2022
@JacobMGEvans
CI/CD check for required variables:
a2f1ee7 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue Apr 28, 2022
@JacobMGEvans
CI/CD check for required variables:
78d5d30 
Added a check in CI/CD environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in CI/CD scope. The `CLOUDFLARE_API_TOKEN` is necessary in CI/CD scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 2, 2022
@JacobMGEvans
non-TTY check for required variables:
a3c07af 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 2, 2022
@JacobMGEvans
non-TTY check for required variables:
a3757e9 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 2, 2022
@JacobMGEvans
non-TTY check for required variables:
45b4735 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 2, 2022
@JacobMGEvans
non-TTY check for required variables:
e50fa70 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
petebacondarwin pushed a commit that referenced this issue May 3, 2022
@JacobMGEvans @petebacondarwin
non-TTY check for required variables:
cd17369 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
@JacobMGEvans JacobMGEvans moved this from Should-have to In Progress in workers-sdk May 3, 2022
JacobMGEvans added a commit that referenced this issue May 3, 2022
@JacobMGEvans
non-TTY check for required variables:
1700697 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 3, 2022
@JacobMGEvans
non-TTY check for required variables:
370200f 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 3, 2022
@JacobMGEvans
non-TTY check for required variables:
e188b4e 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 4, 2022
@JacobMGEvans
non-TTY check for required variables:
6c3a0e4 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 4, 2022
@JacobMGEvans
non-TTY check for required variables:
ce9db80 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 4, 2022
@JacobMGEvans
non-TTY check for required variables:
f1c3343 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 4, 2022
@JacobMGEvans
non-TTY check for required variables:
50cbe61 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 4, 2022
@JacobMGEvans
non-TTY check for required variables:
2d25942 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 4, 2022
@JacobMGEvans
non-TTY check for required variables:
569dedb 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 4, 2022
@JacobMGEvans
non-TTY check for required variables:
16b92d5 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 4, 2022
@JacobMGEvans
non-TTY check for required variables:
dca0292 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 4, 2022
@JacobMGEvans
non-TTY check for required variables:
40a5f50 
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
JacobMGEvans added a commit that referenced this issue May 4, 2022
@JacobMGEvans
non-TTY required variables checks (#852)
6283ad5 
* non-TTY check for required variables:
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827

* non-TTY check for required variables:
Added a check in non-TTY environments for `account_id`, `CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`. If `account_id` exists in `wrangler.toml`
then `CLOUDFLARE_ACCOUNT_ID` is not needed in non-TTY scope. The `CLOUDFLARE_API_TOKEN` is necessary in non-TTY scope and will always error if missing.

resolves #827
Repository owner moved this from In Progress to Done in workers-sdk May 4, 2022
@github-actions github-actions bot mentioned this issue May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobMGEvans JacobMGEvans

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@threepointone @JacobMGEvans