Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: Better Error Message for when Wrangler Login Fails when using Cloudflare Warp #850

Closed
lauragift21 opened this issue Apr 26, 2022 · 1 comment
Closed

🐛 BUG: Better Error Message for when Wrangler Login Fails when using Cloudflare Warp #850

lauragift21 opened this issue Apr 26, 2022 · 1 comment

Comments

@lauragift21
Copy link
Contributor

What version of Wrangler are you using?

0.0.19

What operating system are you using?

Mac

Describe the Bug

I tried running the wrangler login command but it timed out with this error message.

Screenshot 2022-04-26 at 15 23 28

I was able to fix it by turning off WARP and retying the login process and it worked. We should include a better error message instead that tell me what the issue is and catch the error returned.
@lauragift21 lauragift21 changed the title 🐛 BUG: Better Error Message for Wrangler Login Fails 🐛 BUG: Better Error Message for when Wrangler Login Fails Apr 26, 2022
@threepointone threepointone changed the title 🐛 BUG: Better Error Message for when Wrangler Login Fails 🐛 BUG: Better Error Message for when Wrangler Login Fails when using Cloudflare Warp Apr 26, 2022
@threepointone threepointone mentioned this issue May 11, 2022
Merged
threepointone added a commit that referenced this issue May 11, 2022
@threepointone
fix: work with Cloudflare WARP
0d810e9 
Using wrangler with Cloudflare WARP (https://developers.cloudflare.com/cloudflare-one/connections/connect-devices/warp/) requires using the Cloudflare certificate. This patch simply uses the certificate as NODE_EXTRA_CA_CERTS when we start wrangler.

Test plan:

- Turn on Cloudflare WARP/ Gateway with WARP
- `wrangler dev`
- Turn on Cloudflare WARP/ Gateway with DoH
- `wrangler dev`
- Turn off Cloudflare WARP
- `wrangler dev`

Fixes #953, #850
threepointone added a commit that referenced this issue May 11, 2022
@threepointone
fix: work with Cloudflare WARP
ad1ce22 
Using wrangler with Cloudflare WARP (https://developers.cloudflare.com/cloudflare-one/connections/connect-devices/warp/) requires using the Cloudflare certificate. This patch simply uses the certificate as NODE_EXTRA_CA_CERTS when we start wrangler.

Test plan:

- Turn on Cloudflare WARP/ Gateway with WARP
- `wrangler dev`
- Turn on Cloudflare WARP/ Gateway with DoH
- `wrangler dev`
- Turn off Cloudflare WARP
- `wrangler dev`

Fixes #953, #850
threepointone added a commit that referenced this issue May 11, 2022
@threepointone
fix: work with Cloudflare WARP (#963)
5b03eb8 
Using wrangler with Cloudflare WARP (https://developers.cloudflare.com/cloudflare-one/connections/connect-devices/warp/) requires using the Cloudflare certificate. This patch simply uses the certificate as NODE_EXTRA_CA_CERTS when we start wrangler.

Test plan:

- Turn on Cloudflare WARP/ Gateway with WARP
- `wrangler dev`
- Turn on Cloudflare WARP/ Gateway with DoH
- `wrangler dev`
- Turn off Cloudflare WARP
- `wrangler dev`

Fixes #953, #850
@github-actions github-actions bot mentioned this issue May 11, 2022
Merged
@threepointone
Copy link
Contributor

Fixed properly in #963, we don't need to have an error anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@threepointone @lauragift21