Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull out --legacy-env from global flags #933

Closed
GregBrimble opened this issue May 9, 2022 · 0 comments · Fixed by #957 or #954
Closed

Pull out --legacy-env from global flags #933

GregBrimble opened this issue May 9, 2022 · 0 comments · Fixed by #957 or #954
Assignees
@JacobMGEvans
Labels
polish Small improvements to the experience

Comments

@GregBrimble
Copy link
Contributor

It affects a subset of commands (e.g. publish, dev, tail and secret) but not all others (e.g. pages, r2). Like --env and --local, it should be removed as a global flag and added to those specific commands that use it.
@GregBrimble GregBrimble added the polish Small improvements to the experience label May 9, 2022
@JacobMGEvans JacobMGEvans self-assigned this May 10, 2022
JacobMGEvans added a commit that referenced this issue May 10, 2022
@JacobMGEvans
refactor: Moving --legacy-env out of global
2332f75 
The `--legacy-env` flag was in global scope, which only certain commands
utilize the flag for functionality, and doesnt do anything for the other commands.

resolves #933
@JacobMGEvans JacobMGEvans mentioned this issue May 10, 2022
Merged
JacobMGEvans added a commit that referenced this issue May 10, 2022
@JacobMGEvans
refactor: Moving --legacy-env out of global
6b6657a 
The `--legacy-env` flag was in global scope, which only certain commands
utilize the flag for functionality, and doesnt do anything for the other commands.

resolves #933
@petebacondarwin petebacondarwin moved this to In Review in workers-sdk May 10, 2022
@petebacondarwin petebacondarwin added this to the 2.0 milestone May 10, 2022
JacobMGEvans added a commit that referenced this issue May 10, 2022
@JacobMGEvans
refactor: Moving --legacy-env out of global
073bdde 
The `--legacy-env` flag was in global scope, which only certain commands
utilize the flag for functionality, and doesnt do anything for the other commands.

resolves #933
petebacondarwin pushed a commit that referenced this issue May 10, 2022
@JacobMGEvans
refactor: Moving --legacy-env out of global (#957)
e0a0509 
The `--legacy-env` flag was in global scope, which only certain commands
utilize the flag for functionality, and doesnt do anything for the other commands.

resolves #933
Repository owner moved this from In Review to Done in workers-sdk May 10, 2022
@github-actions github-actions bot mentioned this issue May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobMGEvans JacobMGEvans

Labels
polish Small improvements to the experience
Projects
None yet
Milestone
No milestone
3 participants
@petebacondarwin @GregBrimble @JacobMGEvans