fix: ensure that the proxy server shuts down to prevent wrangler dev from hanging
#1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` from hanging When running `wrangler dev` we create a proxy to the actual remote Worker. After creating a connection to this proxy by a browser request the proxy did not shutdown. Now we use a `HttpTerminator` helper library to force the proxy to close open connections and shutdown correctly. Fixes cloudflare#958
🦋 Changeset detectedLatest commit: 2dfb45e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2370448194/npm-package-wrangler-1088You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1088/npm-package-wrangler-1088Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2370448194/npm-package-wrangler-1088 dev path/to/script.js |
petebacondarwin
added a commit
to petebacondarwin/wrangler2
that referenced
this pull request
May 23, 2022
This "quick-win" refactors some of the code to avoid the use of `any` where possible. Using `any` can cause type-checking to be disabled across the code in unexpectedly wide-impact ways. There is one other use of `any` not touched here because it is fixed by cloudflare#1088 separately.
JacobMGEvans
approved these changes
May 23, 2022
Comment on lines
+331
to
+333
| // Running `proxy.server.close()` does not close open connections, preventing the process from exiting. | ||
| // So we use this `terminator` to close all the connections and force the server to shutdown. | ||
| proxy.terminator.terminate(); |
There was a problem hiding this comment.
The terminate w/ the previous .abort() addition is looking very promising to improve Wrangler graceful shutdown.
petebacondarwin
added a commit
that referenced
this pull request
May 23, 2022
This "quick-win" refactors some of the code to avoid the use of `any` where possible. Using `any` can cause type-checking to be disabled across the code in unexpectedly wide-impact ways. There is one other use of `any` not touched here because it is fixed by #1088 separately.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
wrangler devwe create a proxy to the actual remote Worker.After creating a connection to this proxy by a browser request the proxy did not shutdown.
Now we use a
HttpTerminatorhelper library to force the proxy to close open connections and shutdown correctly.Fixes #958