-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix R2 create bucket endpoint #1653
Conversation
🦋 Changeset detectedLatest commit: b011b62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2848331649/npm-package-wrangler-1653 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1653/npm-package-wrangler-1653 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2848331649/npm-package-wrangler-1653 dev path/to/script.js |
Closes #1654 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @KianNH it wasn't clear. Did you say this still doesn't fix the issue?
Ah - we might have to make a change on our end too. |
It'll fix the request that's sent to the API but it looks like the API rejects the authentication methods used by Using
Using
|
The PUT endpoint has been reverted for now but the POST endpoint will still be the way to go so going to finish up this PR Once the fix for the POST endpoint is out, I'll mark this ready |
b333096
to
cafe672
Compare
Codecov Report
@@ Coverage Diff @@
## main #1653 +/- ##
==========================================
- Coverage 81.42% 81.10% -0.32%
==========================================
Files 90 91 +1
Lines 5975 6012 +37
Branches 1532 1543 +11
==========================================
+ Hits 4865 4876 +11
- Misses 1110 1136 +26
|
@WalshyDev this should be ready to put back to review with the docs update landing in the next couple of days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
The old PUT endpoint was removed in favour of POST
{ "name": "<bucket>" }