Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for nonempty kv id and r2 bucket_name #1667

Merged

Conversation

arjunyel
Copy link
Contributor

Close #1660

In packages/wrangler/src/config/validation.ts I originally tried to get isRequiredProperty to type narrow object. This may be impossible microsoft/TypeScript#31755 (comment) so I casted it manually.

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2022

🦋 Changeset detected

Latest commit: 3ba50bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2879344956/npm-package-wrangler-1667

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1667/npm-package-wrangler-1667

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2879344956/npm-package-wrangler-1667 dev path/to/script.js

@arjunyel
Copy link
Contributor Author

Sorry, not sure why my VS Code didn't run Prettier, fixed

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #1667 (3ba50bc) into main (af669a1) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1667      +/-   ##
==========================================
- Coverage   81.37%   80.94%   -0.44%     
==========================================
  Files          90       90              
  Lines        5955     6071     +116     
  Branches     1527     1560      +33     
==========================================
+ Hits         4846     4914      +68     
- Misses       1109     1157      +48     
Impacted Files Coverage Δ
packages/wrangler/src/config/validation-helpers.ts 97.97% <ø> (ø)
packages/wrangler/src/config/validation.ts 91.57% <100.00%> (+0.06%) ⬆️
packages/wrangler/src/pages/publish.tsx 43.79% <0.00%> (-2.69%) ⬇️
packages/wrangler/src/cfetch/internal.ts 7.69% <0.00%> (-1.77%) ⬇️
packages/wrangler/src/pages/dev.tsx 21.97% <0.00%> (-0.92%) ⬇️
...ages/wrangler/src/__tests__/helpers/mock-cfetch.ts 95.00% <0.00%> (-0.72%) ⬇️
packages/wrangler/src/api/dev.ts 15.38% <0.00%> (ø)
packages/wrangler/src/config-cache.ts 100.00% <0.00%> (ø)
packages/wrangler/src/pages/constants.ts 100.00% <0.00%> (ø)
...angler/src/pages/functions/routes-consolidation.ts 100.00% <0.00%> (ø)
... and 6 more

@Skye-31
Copy link
Contributor

Skye-31 commented Aug 15, 2022

This is missing a changeset by the way (run npx changeset in your terminal to create one)

@arjunyel
Copy link
Contributor Author

Hello I can generate a changeset tonight, just curious what changes need one? The API always rejected empty strings so this didn't seem like a change a user would notice. Thank you!

@threepointone
Copy link
Contributor

Looks good to me. Thank you for the PR!

@threepointone threepointone merged commit ba6451d into cloudflare:main Aug 22, 2022
@github-actions github-actions bot mentioned this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants