-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check for nonempty kv id and r2 bucket_name #1667
fix: check for nonempty kv id and r2 bucket_name #1667
Conversation
🦋 Changeset detectedLatest commit: 3ba50bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2879344956/npm-package-wrangler-1667 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1667/npm-package-wrangler-1667 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2879344956/npm-package-wrangler-1667 dev path/to/script.js |
Sorry, not sure why my VS Code didn't run Prettier, fixed |
Codecov Report
@@ Coverage Diff @@
## main #1667 +/- ##
==========================================
- Coverage 81.37% 80.94% -0.44%
==========================================
Files 90 90
Lines 5955 6071 +116
Branches 1527 1560 +33
==========================================
+ Hits 4846 4914 +68
- Misses 1109 1157 +48
|
This is missing a changeset by the way (run |
Hello I can generate a changeset tonight, just curious what changes need one? The API always rejected empty strings so this didn't seem like a change a user would notice. Thank you! |
Looks good to me. Thank you for the PR! |
Close #1660
In
packages/wrangler/src/config/validation.ts
I originally tried to getisRequiredProperty
to type narrowobject
. This may be impossible microsoft/TypeScript#31755 (comment) so I casted it manually.