Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-JS files when compiling Pages Functions #216

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Ignore non-JS files when compiling Pages Functions #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca43b9e
Ignore non-JS files when compiling Pages Functions
GregBrimble Jan 7, 2022
cade6c8
Add support for `jsx` and `tsx` file extensions
GregBrimble Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fluffy-insects-clap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

Ignore non-JS files when compiling Pages Functions
2 changes: 1 addition & 1 deletion packages/wrangler/pages/functions/filepath-routing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export async function generateConfigFromFileTree({

await forEachFile(baseDir, async (filepath) => {
const ext = path.extname(filepath);
if (/\.(mjs|js|ts)/.test(ext)) {
if (/^\.(mjs|js|ts|tsx|jsx)$/.test(ext)) {
// transform the code to ensure we're working with vanilla JS + ESM
const { code } = await transform(await fs.readFile(filepath, "utf-8"), {
loader: ext === ".ts" ? "ts" : "js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh hmm maybe you should do a check for .tsx here too?

Expand Down