-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to dashboard when Queue commands fail due to being unauthorized #2208
Add link to dashboard when Queue commands fail due to being unauthorized #2208
Conversation
🦋 Changeset detectedLatest commit: 28cfd45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
99e15de
to
5b46713
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/3513592692/npm-package-wrangler-2208 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/2208/npm-package-wrangler-2208 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/3513592692/npm-package-wrangler-2208 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.developers.workers.dev/runs/3513592692/npm-package-cloudflare-pages-shared-2208 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changeset
Done, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some test snapshots need to be updated it looks like. The command is npm test -w wrangler -- -u
FAIL src/__tests__/queues.test.ts
● wrangler › queues › create › should show link to dash when not enabled
expect(received).toMatchInlineSnapshot(snapshot)
Snapshot name: `wrangler queues create should show link to dash when not enabled 1`
- Snapshot - 0
+ Received + 0
@@ -7,5 +7,5 @@
If you think this is a bug, please open an issue at:
https://github.com/cloudflare/wrangler2/issues/new/choose
↵
178 | runWrangler(`queues create ${queueName}`)
179 | ).rejects.toThrowError();
> 180 | expect(std.out).toMatchInlineSnapshot(`"Creating queue testQueue.
| ^
181 | You do not have Queues enabled on your account. Go to https://dash.staging.cloudflare.com/some-account-id/workers/queues to enable.
182 |
183 | X [ERROR] A request to the Cloudflare API (/accounts/some-account-id/workers/queues) failed.
at Object.<anonymous> (src/__tests__/queues.test.ts:180:21)
@JacobMGEvans Here I was, editing the snapshots by hand... |
Codecov Report
@@ Coverage Diff @@
## main #2208 +/- ##
=======================================
Coverage 71.79% 71.79%
=======================================
Files 145 146 +1
Lines 9452 9485 +33
Branches 2463 2472 +9
=======================================
+ Hits 6786 6810 +24
- Misses 2666 2675 +9
|
😅 I have done that. I am glad I could provide a better workflow for you 😃 |
Co-authored-by: Matt Silverlock <matt@eatsleeprepeat.net>
e6f8b07
to
1e2e2de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI for future PRs: #2205
No description provided.