Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pretty-error page when using --experimental-local #2249

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Enable pretty-error page when using --experimental-local #2249

merged 2 commits into from
Nov 21, 2022

Commits on Nov 21, 2022

  1. Fix file-watching when using middleware with service workers 

    Previously, when middleware was enabled, service worker user code was
being bundled as part of the middleware facade application, not in
the final bundling step with `watch` enabled. This meant changes to
user code were not picked up. This change restructures the service
worker middleware loader and bundling code as an IIFE, that gets
injected into the final bundle. This also has the positive side
effect that middleware internals aren't exposed to users.
    @mrbbot
    mrbbot committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    cf0be64 View commit details
    Browse the repository at this point in the history

  2. Enable pretty-error page when using --experimental-local 

    This PR enables Miniflare 3's pretty-error page with middleware. See
cloudflare/miniflare#436 for an explanation of why we need to do this
in the first place.
    @mrbbot
    mrbbot committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    8d693a0 View commit details
    Browse the repository at this point in the history