Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix the release github workflow #2998

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

petebacondarwin
Copy link
Contributor

This workflow was failing whenever there was a minor release to wrangler and a patch release to a package that depended upon wrangler. It was caused by a bug in npm that was resolved in v8.5.0. See npm/cli#4379 and npm/cli#4371. The error looks like: No matching version found for wrangler@^2.15.0.

This workflow was failing whenever there was a minor release to wrangler
and a patch release to a package that depended upon wrangler.
It was caused by a bug in npm that was resolved in v8.5.0.
See npm/cli#4379 and npm/cli#4371.
The error looks like: `No matching version found for wrangler@^2.15.0.`
@petebacondarwin petebacondarwin requested a review from a team as a code owner April 6, 2023 11:41
@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2023

⚠️ No Changeset found

Latest commit: 66dd51c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4628489949/npm-package-wrangler-2998

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/2998/npm-package-wrangler-2998

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4628489949/npm-package-wrangler-2998 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/4628489949/npm-package-cloudflare-pages-shared-2998

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #2998 (66dd51c) into main (ccae0e4) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2998      +/-   ##
==========================================
+ Coverage   73.84%   73.87%   +0.02%     
==========================================
  Files         167      167              
  Lines       10504    10504              
  Branches     2807     2807              
==========================================
+ Hits         7757     7760       +3     
+ Misses       2747     2744       -3     

see 2 files with indirect coverage changes

@petebacondarwin petebacondarwin merged commit e7cf0ca into cloudflare:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants