-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Templates]: Add QR Code Generator to Examples #3490
Conversation
|
f4f8c63
to
eb15275
Compare
Codecov Report
@@ Coverage Diff @@
## main #3490 +/- ##
==========================================
- Coverage 75.18% 75.12% -0.06%
==========================================
Files 183 190 +7
Lines 11055 11109 +54
Branches 2904 2919 +15
==========================================
+ Hits 8312 8346 +34
- Misses 2743 2763 +20 |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9869932731/npm-package-wrangler-3490 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3490/npm-package-wrangler-3490 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9869932731/npm-package-wrangler-3490 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9869932731/npm-package-create-cloudflare-3490 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9869932731/npm-package-cloudflare-kv-asset-handler-3490 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9869932731/npm-package-miniflare-3490 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9869932731/npm-package-cloudflare-pages-shared-3490 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9869932731/npm-package-cloudflare-vitest-pool-workers-3490 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if the newer templates were in TypeScript. It is easier to downgrade to JS then it is to setup a TS environment from scratch.
4d21777
to
ca73da0
Compare
Thanks, @JacobMGEvans! This is an example from one of the tutorials, rather than a template. but I've gone ahead to update it to a TS version. |
ca73da0
to
505b4c8
Compare
can you add a {
"compilerOptions": {
"noEmit": true,
"module": "esnext",
"target": "esnext",
"lib": ["esnext"],
"strict": true,
"moduleResolution": "node",
"types": ["@cloudflare/workers-types"]
},
"exclude": ["node_modules"]
} |
0095149
to
cba9295
Compare
Co-authored-by: James Ross <james@jross.me>
cba9295
to
842cae5
Compare
Out of interest I tried this out with (rather than It totally failed to build with
With
Something to fix before we go GA with nodejs_v2 @IgorMinar, @jculvey and @jasnell ? |
Fixes # [insert GH or internal issue number(s)].
What this PR solves / how to test:
Add a QR Code Source code to examples directory
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable: