C3: Add e2e coverage for deployment

[jculvey]

Adds e2e coverage for the deployment bits of c3

What this PR solves / how to test:

Associated docs issue(s)/PR(s):

• [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

• [ x ] Tests
• Changeset (Changeset guidelines)

Reviewer is to perform the following, as applicable:

• Checked for inclusion of relevant tests
• Checked for inclusion of a relevant changeset
• Checked for creation of associated docs updates
• Manually pulled down the changes and spot-tested

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1845864

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

Merging #3658 (1845864) into main (ccc19d5) will increase coverage by 0.10%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3658      +/-   ##
==========================================
+ Coverage   74.98%   75.08%   +0.10%     
==========================================
  Files         194      195       +1     
  Lines       11301    11351      +50     
  Branches     2977     2999      +22     
==========================================
+ Hits         8474     8523      +49     
- Misses       2827     2828       +1     

see 12 files with indirect coverage changes

[dario-piotrowicz]

Looks good to me 😃

One thing I am not sure about are the strings you chose for testing the deployments, they seem a bit small to me and potentially a bit unreliable (can those be for example be present also in error pages? like Create Next App?)

On the other hand you wouldn't want them to be long and brittle/flaky, so I get that
(maybe the could be turned to more flexible and reliable regexes if need be? not necessarily right now, I don't want you to overengineer things on my account)

Anyways I trust your judgment 😄

[dario-piotrowicz]

thanks a lot for the changes, awesome stuff 😄

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5685523545/npm-package-wrangler-3658

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5685523545/npm-package-wrangler-3658

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5685523545/npm-package-wrangler-3658 dev path/to/script.js

Additional artifacts:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5685523545/npm-package-cloudflare-pages-shared-3658

Note that these links will no longer work once the GitHub Actions artifact expires.

[petebacondarwin]

Is this not required to ensure that weird paths don't get expanded improperly?