Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C3] Uncomment Queues config lines in Queues C3 templates #3681

Merged

Conversation

kewbish
Copy link
Contributor

@kewbish kewbish commented Jul 27, 2023

What this PR solves / how to test:

  • Previously, running npm create cloudflare and choosing the queues option would copy a wrangler.toml file with the [[queues.producers]] and [[queues.consumers]] lines commented out.
  • This resulted in an Can't redefine existing key error when running wrangler dev.
  • This PR uncomments the [[queues.producers]] and [[queues.consumers]] lines in the template.

Associated docs issue(s)/PR(s):

  • N/A

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@kewbish kewbish requested review from a team as code owners July 27, 2023 19:56
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

⚠️ No Changeset found

Latest commit: c7a8211

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5684885798/npm-package-wrangler-3681

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5684885798/npm-package-wrangler-3681

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5684885798/npm-package-wrangler-3681 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5684885798/npm-package-cloudflare-pages-shared-3681

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #3681 (c7a8211) into main (bfbe49d) will increase coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3681      +/-   ##
==========================================
+ Coverage   75.04%   75.08%   +0.04%     
==========================================
  Files         195      195              
  Lines       11351    11351              
  Branches     2999     2999              
==========================================
+ Hits         8518     8523       +5     
+ Misses       2833     2828       -5     

see 3 files with indirect coverage changes

@kewbish
Copy link
Contributor Author

kewbish commented Aug 8, 2023

@RamIdeas Thank you for the review - could you also merge please? I don't have permissions.

@Skye-31 Skye-31 merged commit 977b3a9 into cloudflare:main Aug 8, 2023
13 checks passed
@kewbish kewbish deleted the ema/fix-queues-template-wrangler-toml branch August 8, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants