Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secret:bulk exit 1 on failure #3704

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

JacobMGEvans
Copy link
Contributor

What this PR solves / how to test:
When 'secret:bulk' has an upload request fail it now sends a exit 1 signal that will allow for error handling in other environments.

What this PR solves / how to test:
cloudflare/wrangler-action#112

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

When 'secret:bulk' has an upload request fail it now sends a exit 1 signal that will allow for error handling in other environments.
@JacobMGEvans JacobMGEvans requested review from a team as code owners August 3, 2023 14:59
@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

🦋 Changeset detected

Latest commit: 66326e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5752374531/npm-package-wrangler-3704

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5752374531/npm-package-wrangler-3704

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5752374531/npm-package-wrangler-3704 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5752374531/npm-package-cloudflare-pages-shared-3704

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #3704 (66326e6) into main (ff8603b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3704      +/-   ##
==========================================
+ Coverage   75.17%   75.21%   +0.04%     
==========================================
  Files         195      195              
  Lines       11407    11407              
  Branches     3013     3013              
==========================================
+ Hits         8575     8580       +5     
+ Misses       2832     2827       -5     
Files Changed Coverage Δ
packages/wrangler/src/secret/index.ts 87.32% <100.00%> (ø)

... and 3 files with indirect coverage changes

@JacobMGEvans JacobMGEvans merged commit 8e231af into main Aug 3, 2023
12 checks passed
@JacobMGEvans JacobMGEvans deleted the jacobmgevans/secret-exit-1 branch August 3, 2023 15:17
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
lrapoport-cf pushed a commit that referenced this pull request Aug 11, 2023
When 'secret:bulk' has an upload request fail it now sends a exit 1 signal that will allow for error handling in other environments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants