Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify kv:key list output in local vs remote case #3720

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

JacksonKearl
Copy link
Contributor

@JacksonKearl JacksonKearl commented Aug 8, 2023

Fix #3715, Fix #3716

cc @jspspike feel free to close if you want to diy.

@JacksonKearl JacksonKearl requested a review from a team as a code owner August 8, 2023 17:43
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

⚠️ No Changeset found

Latest commit: 6330de9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5800380762/npm-package-wrangler-3720

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5800380762/npm-package-wrangler-3720

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5800380762/npm-package-wrangler-3720 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5800380762/npm-package-cloudflare-pages-shared-3720

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #3720 (6330de9) into main (6de3c5e) will increase coverage by 0.04%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3720      +/-   ##
==========================================
+ Coverage   75.16%   75.21%   +0.04%     
==========================================
  Files         194      194              
  Lines       11409    11410       +1     
  Branches     3012     3013       +1     
==========================================
+ Hits         8576     8582       +6     
+ Misses       2833     2828       -5     
Files Changed Coverage Δ
packages/wrangler/src/kv/index.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@jspspike jspspike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jspspike jspspike merged commit 94fed9d into cloudflare:main Aug 9, 2023
12 checks passed
lrapoport-cf pushed a commit that referenced this pull request Aug 11, 2023
* Unify `kv:key list` output in local vs remote case
Fix #3715, Fix #3716

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants