Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WC-1559: Add alert when last deployed via API #3727

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

echen67
Copy link
Contributor

@echen67 echen67 commented Aug 9, 2023

Fixes WC-1559.

What this PR solves / how to test:
This PR simply adds a warning when the user tries to deploy and the last deployment was via the API. The warning is similar to the one that appears when the last warning was via the dashboard.

Associated docs issue(s)/PR(s):

  • [insert associated docs issue(s)/PR(s)]

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@echen67 echen67 requested a review from a team as a code owner August 9, 2023 20:40
@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

🦋 Changeset detected

Latest commit: b84d6c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5929778227/npm-package-wrangler-3727

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5929778227/npm-package-wrangler-3727

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5929778227/npm-package-wrangler-3727 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5929778227/npm-package-cloudflare-pages-shared-3727

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #3727 (b84d6c3) into main (94fed9d) will increase coverage by 0.08%.
Report is 16 commits behind head on main.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3727      +/-   ##
==========================================
+ Coverage   75.17%   75.26%   +0.08%     
==========================================
  Files         194      195       +1     
  Lines       11410    11435      +25     
  Branches     3013     3016       +3     
==========================================
+ Hits         8577     8606      +29     
+ Misses       2833     2829       -4     
Files Changed Coverage Δ
...ckages/wrangler/src/__tests__/helpers/msw/index.ts 100.00% <ø> (ø)
packages/wrangler/src/deploy/deploy.ts 87.33% <75.00%> (-0.13%) ⬇️
.../src/__tests__/helpers/msw/handlers/deployments.ts 73.07% <100.00%> (+3.51%) ⬆️

... and 7 files with indirect coverage changes

Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks for the first contribution!! 🎉

I think a test that inline-snapshots the stdout would be good here and a changeset for the change in user flow and messaging. Besides those things everything looks great 😄

@echen67 echen67 requested review from a team as code owners August 21, 2023 15:53
@JacobMGEvans JacobMGEvans merged commit a5e7c0b into cloudflare:main Aug 22, 2023
12 checks passed
@github-actions github-actions bot mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants