-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WC-1559: Add alert when last deployed via API #3727
Conversation
🦋 Changeset detectedLatest commit: b84d6c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5929778227/npm-package-wrangler-3727 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5929778227/npm-package-wrangler-3727 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5929778227/npm-package-wrangler-3727 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5929778227/npm-package-cloudflare-pages-shared-3727 Note that these links will no longer work once the GitHub Actions artifact expires. |
Codecov Report
@@ Coverage Diff @@
## main #3727 +/- ##
==========================================
+ Coverage 75.17% 75.26% +0.08%
==========================================
Files 194 195 +1
Lines 11410 11435 +25
Branches 3013 3016 +3
==========================================
+ Hits 8577 8606 +29
+ Misses 2833 2829 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, thanks for the first contribution!! 🎉
I think a test that inline-snapshots the stdout
would be good here and a changeset for the change in user flow and messaging. Besides those things everything looks great 😄
Fixes WC-1559.
What this PR solves / how to test:
This PR simply adds a warning when the user tries to deploy and the last deployment was via the API. The warning is similar to the one that appears when the last warning was via the dashboard.
Associated docs issue(s)/PR(s):
Author has included the following, where applicable:
Reviewer is to perform the following, as applicable:
Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label
highlight pr review
so future reviewers can take inspiration and learn from it.